You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/04 16:13:55 UTC

[GitHub] [arrow] anthonylouisbsb commented on a change in pull request #12333: ARROW-15568: [C++][Gandiva] Implement Translate Function

anthonylouisbsb commented on a change in pull request #12333:
URL: https://github.com/apache/arrow/pull/12333#discussion_r799604096



##########
File path: cpp/src/gandiva/gdv_function_stubs.cc
##########
@@ -1165,6 +1165,234 @@ int32_t gdv_fn_cast_intervalyear_utf8_int32(int64_t context_ptr, int64_t holder_
   auto* holder = reinterpret_cast<gandiva::IntervalYearsHolder*>(holder_ptr);
   return (*holder)(context, data, data_len, in1_validity, out_valid);
 }
+
+GDV_FORCE_INLINE
+gdv_int32 utf8_char_length(char c) {

Review comment:
       Check if that function already exists in that file, because I remember that some similar function is used in `upper` and `lower` functions




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org