You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicecomb.apache.org by GitBox <gi...@apache.org> on 2017/12/30 03:00:19 UTC

[GitHub] wujimin commented on a change in pull request #472: [JAV-558] pullTask,use rev to ensure data consistency and reduce service center work load

wujimin commented on a change in pull request #472: [JAV-558] pullTask,use rev to ensure data consistency and reduce service center work load
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/472#discussion_r159115687
 
 

 ##########
 File path: service-registry/src/main/java/io/servicecomb/serviceregistry/RegistryUtils.java
 ##########
 @@ -202,9 +202,9 @@ private static IpPort genPublishIpPort(String schema, IpPort ipPort) {
     return new IpPort(publicAddressSetting, publishPort);
   }
 
-  public static List<MicroserviceInstance> findServiceInstance(String appId, String serviceName,
-      String versionRule) {
-    return serviceRegistry.findServiceInstance(appId, serviceName, versionRule);
+  public static MicroserviceInstances findServiceInstance(String appId, String serviceName,
 
 Review comment:
   cause not compatible?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services