You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "Robert Burrell Donkin (JIRA)" <se...@james.apache.org> on 2007/07/16 22:30:04 UTC

[jira] Commented: (MIME4J-19) Pull Parser

    [ https://issues.apache.org/jira/browse/MIME4J-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12513017 ] 

Robert Burrell Donkin commented on MIME4J-19:
---------------------------------------------

I'm very, very keen to see this patch included in the code base.

I'm working on factoring out a cursor so that the same state machine can be used for both byte buffers and input streams. This should allow me to use mime4j correctly parse the byte arrays used in the current IMAP implementation. This refactoring would also make it easier to add experimental new algorithms to parse large messages more efficiently.

Robert

> Pull Parser
> -----------
>
>                 Key: MIME4J-19
>                 URL: https://issues.apache.org/jira/browse/MIME4J-19
>             Project: Mime4j
>          Issue Type: New Feature
>    Affects Versions: 0.3
>            Reporter: Jochen Wiedmann
>             Fix For: 0.4
>
>         Attachments: mime4j-iterator.patch
>
>
> The attached patch introduces a new class called MimeTokenStream, which is a "Pull Parser" for MIME documents. The class is basically a rewrite of the MimeStreamParser. The patch does also provide a rewrite of the MimeStreamParser itself, based on the MimeTokenStream.
> Pull parsers are technically a little bit more difficult. However, from the users perspective, they are much more preferrable, because writing an application on top of a pull parser is much easier than based on an event handler.
> I would like to rewrite the commons-fileupload component based on mime4j. However, as commons-fileupload provides a pull parser API, we depend on the presence of a similar API in mime4j. Not providing a pull parser API would mean, that we'd need to duplicate mime4j code into commons-fileupload, which is certainly not desirable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Re: [jira] Commented: (MIME4J-19) Pull Parser

Posted by Stefano Bagnara <ap...@bago.org>.
Robert Burrell Donkin (JIRA) ha scritto:
>     [ https://issues.apache.org/jira/browse/MIME4J-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12513017 ] 
> 
> Robert Burrell Donkin commented on MIME4J-19:
> ---------------------------------------------
> 
> I'm very, very keen to see this patch included in the code base.
> 
> I'm working on factoring out a cursor so that the same state machine can be used for both byte buffers and input streams. This should allow me to use mime4j correctly parse the byte arrays used in the current IMAP implementation. This refactoring would also make it easier to add experimental new algorithms to parse large messages more efficiently.

+1 Sounds like the best plan.

Stefano


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Re: [jira] Commented: (MIME4J-19) Pull Parser

Posted by Robert Burrell Donkin <ro...@gmail.com>.
On 7/19/07, norman <no...@apache.org> wrote:
> Am Mittwoch, den 18.07.2007, 22:51 +0100 schrieb robert burrell donkin:
> > On 7/18/07, Norman Maurer <no...@apache.org> wrote:
> > > Just go ahead and commit the patch if you want. My time is very limited at the moment.
> >
> > anything else i need to check? (other than that the tests run)
> >
> > what about those additional emails?
> >
> > - robert
>
>
> Well if the tests pass I think it worth to include it.

oops missed this email :-/

- robert

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Re: [jira] Commented: (MIME4J-19) Pull Parser

Posted by norman <no...@apache.org>.
Am Mittwoch, den 18.07.2007, 22:51 +0100 schrieb robert burrell donkin:
> On 7/18/07, Norman Maurer <no...@apache.org> wrote:
> > Just go ahead and commit the patch if you want. My time is very limited at the moment.
> 
> anything else i need to check? (other than that the tests run)
> 
> what about those additional emails?
> 
> - robert


Well if the tests pass I think it worth to include it. 

bye
Norman


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Re: [jira] Commented: (MIME4J-19) Pull Parser

Posted by robert burrell donkin <ro...@gmail.com>.
On 7/18/07, Norman Maurer <no...@apache.org> wrote:
> Just go ahead and commit the patch if you want. My time is very limited at the moment.

anything else i need to check? (other than that the tests run)

what about those additional emails?

- robert

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Re: [jira] Commented: (MIME4J-19) Pull Parser

Posted by Norman Maurer <no...@apache.org>.
Just go ahead and commit the patch if you want. My time is very limited at the moment.

bye
Norman



On Mon, 16 Jul 2007 13:30:04 -0700 (PDT), "Robert Burrell Donkin (JIRA)" <se...@james.apache.org> wrote:
> 
>     [
> https://issues.apache.org/jira/browse/MIME4J-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12513017
> ]
> 
> Robert Burrell Donkin commented on MIME4J-19:
> ---------------------------------------------
> 
> I'm very, very keen to see this patch included in the code base.
> 
> I'm working on factoring out a cursor so that the same state machine can
> be used for both byte buffers and input streams. This should allow me to
> use mime4j correctly parse the byte arrays used in the current IMAP
> implementation. This refactoring would also make it easier to add
> experimental new algorithms to parse large messages more efficiently.
> 
> Robert
> 
>> Pull Parser
>> -----------
>>
>>                 Key: MIME4J-19
>>                 URL: https://issues.apache.org/jira/browse/MIME4J-19
>>             Project: Mime4j
>>          Issue Type: New Feature
>>    Affects Versions: 0.3
>>            Reporter: Jochen Wiedmann
>>             Fix For: 0.4
>>
>>         Attachments: mime4j-iterator.patch
>>
>>
>> The attached patch introduces a new class called MimeTokenStream, which
> is a "Pull Parser" for MIME documents. The class is basically a rewrite of
> the MimeStreamParser. The patch does also provide a rewrite of the
> MimeStreamParser itself, based on the MimeTokenStream.
>> Pull parsers are technically a little bit more difficult. However, from
> the users perspective, they are much more preferrable, because writing an
> application on top of a pull parser is much easier than based on an event
> handler.
>> I would like to rewrite the commons-fileupload component based on
> mime4j. However, as commons-fileupload provides a pull parser API, we
> depend on the presence of a similar API in mime4j. Not providing a pull
> parser API would mean, that we'd need to duplicate mime4j code into
> commons-fileupload, which is certainly not desirable.
> 
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
> 
> 
> !DSPAM:1,469bd570240375636457488!


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org