[GitHub] curator pull request #197: [CURATOR-367] Delay reconnect on session expired

[Randgalt <gi...@git.apache.org>]

Github user Randgalt commented on a diff in the pull request:

    https://github.com/apache/curator/pull/197#discussion_r103324303
  
    --- Diff: curator-client/src/main/java/org/apache/curator/ConnectionState.java ---
    @@ -283,12 +300,19 @@ private boolean checkState(Event.KeeperState state, boolean wasConnected)
                 new EventTrace(state.toString(), tracer.get(), getSessionId()).commit();
             }
     
    -        if ( checkNewConnectionString && zooKeeper.hasNewConnectionString() )
    +        return isConnected;
    +    }
    +
    +    private void handleState(Event.KeeperState state)
    +    {
    +        if (state == Event.KeeperState.Expired)
    +        {
    +            handleExpiredSession();
    --- End diff --
    
    We've lost functionality here right? If there's a new connection string and an expired session we don't get the new connection string.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---