You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2019/04/25 17:48:42 UTC
[Impala-ASF-CR] IMPALA-8119: document how to set heap size in docker
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13119
Change subject: IMPALA-8119: document how to set heap size in docker
......................................................................
IMPALA-8119: document how to set heap size in docker
JAVA_TOOL_OPTIONS is a standard mechanism to pass arguments to a JVM.
Let's just document this as the canonical way to pass in the heap size.
Change-Id: Ie6ddba3c42a698b52d7c4e2ff6a9c73068e198b2
---
M bin/start-impala-cluster.py
M docker/README.md
M docker/daemon_entrypoint.sh
3 files changed, 9 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/13119/1
--
To view, visit http://gerrit.cloudera.org:8080/13119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie6ddba3c42a698b52d7c4e2ff6a9c73068e198b2
Gerrit-Change-Number: 13119
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8119: document how to set heap size in docker
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13119 )
Change subject: IMPALA-8119: document how to set heap size in docker
......................................................................
IMPALA-8119: document how to set heap size in docker
JAVA_TOOL_OPTIONS is a standard mechanism to pass arguments to a JVM.
Let's just document this as the canonical way to pass in the heap size.
Change-Id: Ie6ddba3c42a698b52d7c4e2ff6a9c73068e198b2
Reviewed-on: http://gerrit.cloudera.org:8080/13119
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/start-impala-cluster.py
M docker/README.md
M docker/daemon_entrypoint.sh
3 files changed, 9 insertions(+), 9 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/13119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie6ddba3c42a698b52d7c4e2ff6a9c73068e198b2
Gerrit-Change-Number: 13119
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-8119: document how to set heap size in docker
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13119 )
Change subject: IMPALA-8119: document how to set heap size in docker
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2916/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6ddba3c42a698b52d7c4e2ff6a9c73068e198b2
Gerrit-Change-Number: 13119
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Apr 2019 18:15:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8119: document how to set heap size in docker
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13119 )
Change subject: IMPALA-8119: document how to set heap size in docker
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4069/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/13119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6ddba3c42a698b52d7c4e2ff6a9c73068e198b2
Gerrit-Change-Number: 13119
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Apr 2019 21:12:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8119: document how to set heap size in docker
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13119 )
Change subject: IMPALA-8119: document how to set heap size in docker
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6ddba3c42a698b52d7c4e2ff6a9c73068e198b2
Gerrit-Change-Number: 13119
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Apr 2019 02:28:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8119: document how to set heap size in docker
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13119 )
Change subject: IMPALA-8119: document how to set heap size in docker
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6ddba3c42a698b52d7c4e2ff6a9c73068e198b2
Gerrit-Change-Number: 13119
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Apr 2019 21:12:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8119: document how to set heap size in docker
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13119 )
Change subject: IMPALA-8119: document how to set heap size in docker
......................................................................
Patch Set 1: Code-Review+2
Good to get this cleaned up
--
To view, visit http://gerrit.cloudera.org:8080/13119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6ddba3c42a698b52d7c4e2ff6a9c73068e198b2
Gerrit-Change-Number: 13119
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Apr 2019 20:33:30 +0000
Gerrit-HasComments: No