You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2021/03/03 03:00:11 UTC

[GitHub] [servicecomb-pack] coolbeevip opened a new pull request #701: [SCB-2202] Improve ForwardRecoveryTest.throwExceptionWhenRetryReachesMaximum

coolbeevip opened a new pull request #701:
URL: https://github.com/apache/servicecomb-pack/pull/701


   ForwardRecoveryTest.throwExceptionWhenRetryReachesMaximum failure in poor performance host


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-pack] coolbeevip commented on a change in pull request #701: [SCB-2202] Improve ForwardRecoveryTest.throwExceptionWhenRetryReachesMaximum

Posted by GitBox <gi...@apache.org>.
coolbeevip commented on a change in pull request #701:
URL: https://github.com/apache/servicecomb-pack/pull/701#discussion_r586135302



##########
File path: omega/omega-transaction/src/test/java/org/apache/servicecomb/pack/omega/transaction/ForwardRecoveryTest.java
##########
@@ -155,7 +155,7 @@ public void throwExceptionWhenRetryReachesMaximum() throws Throwable {
           containsString("Failed to handle tx because it is interrupted")));
     }
 
-    assertThat(messages.size(), is(3));
+    await().atMost(10, SECONDS).until(() -> messages.size() == 3);

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-pack] WillemJiang commented on a change in pull request #701: [SCB-2202] Improve ForwardRecoveryTest.throwExceptionWhenRetryReachesMaximum

Posted by GitBox <gi...@apache.org>.
WillemJiang commented on a change in pull request #701:
URL: https://github.com/apache/servicecomb-pack/pull/701#discussion_r586110579



##########
File path: omega/omega-transaction/src/test/java/org/apache/servicecomb/pack/omega/transaction/ForwardRecoveryTest.java
##########
@@ -155,7 +155,7 @@ public void throwExceptionWhenRetryReachesMaximum() throws Throwable {
           containsString("Failed to handle tx because it is interrupted")));
     }
 
-    assertThat(messages.size(), is(3));
+    await().atMost(10, SECONDS).until(() -> messages.size() == 3);

Review comment:
       Please don't use the lamda founction in omega side which only supports  Java7 syntax. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-pack] coveralls commented on pull request #701: [SCB-2202] Improve ForwardRecoveryTest.throwExceptionWhenRetryReachesMaximum

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #701:
URL: https://github.com/apache/servicecomb-pack/pull/701#issuecomment-789446227


   
   [![Coverage Status](https://coveralls.io/builds/37605519/badge)](https://coveralls.io/builds/37605519)
   
   Coverage decreased (-0.04%) to 80.656% when pulling **3d55393b5d4d3e4a3ff0af1a1fd7f2c934d61ae2 on coolbeevip:SCB-2202** into **56828396685d55c580b5b410f19b80530902e696 on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-pack] WillemJiang merged pull request #701: [SCB-2202] Improve ForwardRecoveryTest.throwExceptionWhenRetryReachesMaximum

Posted by GitBox <gi...@apache.org>.
WillemJiang merged pull request #701:
URL: https://github.com/apache/servicecomb-pack/pull/701


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org