[jira] [Commented] (NUTCH-1306) Commit after finished writing to solr index

["Ferdy Galema (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NUTCH-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272231#comment-13272231 ] 

Ferdy Galema commented on NUTCH-1306:
-------------------------------------

Lewis,

Do you suggest to add the commit as implemented by the fix but make it conditional? Something like this:

if (getConf().getBoolean("solr.commit", true)) {
  solr.commit()
}

This makes it enabled by default. I think it is a good idea.

Secondly, you say that Nutchgora does not commit at all. It looks like trunk does not commit either. I think it's a bit confusing the COMMIT_SIZE nutch property does no solr commit but rather 'flush' data to solr. Perhaps we could clarify this a bit more. (Update the property description by mentioning the fact that it does NOT trigger a solr commit.) Agree?
                
> Commit after finished writing to solr index
> -------------------------------------------
>
>                 Key: NUTCH-1306
>                 URL: https://issues.apache.org/jira/browse/NUTCH-1306
>             Project: Nutch
>          Issue Type: Improvement
>          Components: indexer
>    Affects Versions: nutchgora
>            Reporter: Dan Rosher
>            Priority: Trivial
>             Fix For: 2.1
>
>         Attachments: NUTCH-1306.patch
>
>
> Commit after finished writing to solr index - otherwise a bit confusing not seeing the number of docs we expect in solr

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira