You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/16 11:54:05 UTC
[GitHub] [incubator-superset] cah-arunkumarpasula opened a new issue #9557:
FilterBox is working as expected
cah-arunkumarpasula opened a new issue #9557: FilterBox is working as expected
URL: https://github.com/apache/incubator-superset/issues/9557
A clear and concise description of what the bug is.
I was confused about the filter box functionality.I have a dashboard with two three charts, one of which is filterbox used to filter the other two.
When I select a value from filter, then change it and select another value, seems the chart is taking in the previous filter value too resulting in malformed sql and no data for that chart.
### Expected results
When I select a value from the filter the query under the hood should consider only the same and return the results if any
### Actual results
say I select CVS pharmacy from filterbox field to see the stats for them . I have two other charts in the dashboard. This works fine and next when I select another pharmacy, say, Walgreens by clearing previous filter..the chart says no data which is not correct.
This is because the query formed under the hood for the chart with no data when I click on explore chart shows me filters like this:
IN(CVS PHARMACY)
IN(WALGREENS)
instead of just one IN condition
I selected :
Chart with No Data has the filters:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ramdesh edited a comment on issue #9557:
FilterBox is not working as expected
Posted by GitBox <gi...@apache.org>.
ramdesh edited a comment on issue #9557: FilterBox is not working as expected
URL: https://github.com/apache/incubator-superset/issues/9557#issuecomment-614724849
Just to add some context to this, in the above filter, the first run sends out the correct filters, but on clicking 'clear' and choosing another filter, it seems to send the old filters to the backend as well. Here is the `form_data` that is sent to the backend:
```
{
"datasource":"446__table",
"viz_type":"dist_bar",
"slice_id":435,
"granularity_sqla":"year",
"time_grain_sqla":"P1D",
"time_range":"100 years ago : ",
"metrics":[
{
"aggregate":"COUNT",
"column":{
"column_name":"centerID",
"description":null,
"expression":null,
"filterable":true,
"groupby":true,
"id":5699,
"is_dttm":false,
"optionName":"_col_centerID",
"python_date_format":null,
"type":"INT",
"verbose_name":null
},
"expressionType":"SIMPLE",
"fromFormData":true,
"hasCustomLabel":true,
"label":"Total Pharmacies",
"optionName":"metric_1aiyetjyng4_9dblxojmirk",
"sqlExpression":null
}
],
"adhoc_filters":[
{
"clause":"WHERE",
"comparator":[
"WALGREENS DRUG STORE ",
"ACME PHARMACY "
],
"expressionType":"SIMPLE",
"filterOptionName":"aa4d0ae1-36b0-4483-812d-4e12d71ebe42",
"operator":"in",
"subject":"chainNM"
}
],
"groupby":[
"year",
"quarter"
],
"columns":[
],
"row_limit":1000,
"contribution":false,
"color_scheme":"bnbColors",
"label_colors":{
"Total Pharmacies":"#ff5a5f"
},
"show_legend":true,
"show_bar_value":false,
"bar_stacked":false,
"order_bars":true,
"y_axis_format":"SMART_NUMBER",
"y_axis_label":"total pharmacies",
"show_controls":false,
"x_axis_label":"time",
"bottom_margin":"auto",
"x_ticks_layout":"auto",
"reduce_x_ticks":true,
"extra_filters":[
{
"col":"chainNM",
"op":"in",
"val":[
"CVS PHARMACY INC "
]
}
]
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ramdesh commented on issue #9557: FilterBox is
not working as expected
Posted by GitBox <gi...@apache.org>.
ramdesh commented on issue #9557: FilterBox is not working as expected
URL: https://github.com/apache/incubator-superset/issues/9557#issuecomment-614724849
Just to add some context to this, in the above filter, the first run sends out the correct filters, but on clicking 'clear' and choosing another filter, it seems to send the old filters to the backend as well. Here is the `form_data` that is sent to the backend:
```
{"datasource":"446__table","viz_type":"dist_bar","slice_id":435,"granularity_sqla":"year","time_grain_sqla":"P1D","time_range":"100 years ago : ","metrics":[{"aggregate":"COUNT","column":{"column_name":"centerID","description":null,"expression":null,"filterable":true,"groupby":true,"id":5699,"is_dttm":false,"optionName":"_col_centerID","python_date_format":null,"type":"INT","verbose_name":null},"expressionType":"SIMPLE","fromFormData":true,"hasCustomLabel":true,"label":"Total Pharmacies","optionName":"metric_1aiyetjyng4_9dblxojmirk","sqlExpression":null}],"adhoc_filters":[{"clause":"WHERE","comparator":["WALGREENS DRUG STORE ","ACME PHARMACY "],"expressionType":"SIMPLE","filterOptionName":"aa4d0ae1-36b0-4483-812d-4e12d71ebe42","operator":"in","subject":"chainNM"}],"groupby":["year","quarter"],"columns":[],"row_limit":1000,"contribution":false,"color_scheme":"bnbColors","label_colors":{"Total Pharmacies":"#ff5a5f"},"show_legend":true,"show_bar_value":false,"bar_stacked":false,"order_bars":true,"y_axis_format":"SMART_NUMBER","y_axis_label":"total pharmacies","show_controls":false,"x_axis_label":"time","bottom_margin":"auto","x_ticks_layout":"auto","reduce_x_ticks":true,"extra_filters":[{"col":"chainNM","op":"in","val":["CVS PHARMACY INC "]}]}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] cah-arunkumarpasula commented on issue #9557: FilterBox is not working as expected
Posted by GitBox <gi...@apache.org>.
cah-arunkumarpasula commented on issue #9557:
URL: https://github.com/apache/incubator-superset/issues/9557#issuecomment-632118866
I still see the issue. Appreciate any help.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] stale[bot] closed issue #9557: FilterBox is not working as expected
Posted by GitBox <gi...@apache.org>.
stale[bot] closed issue #9557:
URL: https://github.com/apache/incubator-superset/issues/9557
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on issue #9557: FilterBox is not working as expected
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on issue #9557:
URL: https://github.com/apache/incubator-superset/issues/9557#issuecomment-632453743
I could not reproduce. I used the "World Bank Data" example and added / removed filters hoping to recreate and couldn't. What version are you on? Can you reproduce against `master`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] stale[bot] commented on issue #9557: FilterBox is not working as expected
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on issue #9557:
URL: https://github.com/apache/incubator-superset/issues/9557#issuecomment-663807200
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] Dragonwarrior47 commented on issue #9557: FilterBox is not working as expected
Posted by GitBox <gi...@apache.org>.
Dragonwarrior47 commented on issue #9557:
URL: https://github.com/apache/incubator-superset/issues/9557#issuecomment-671860984
@cah-arunkumarpasula cah-arunkumarpasula I am also facing this issue how did you resolve it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org