[GitHub] [dolphinscheduler] Radeity commented on a diff in pull request #12197: [Improvement][Task] Improved way to collect yarn job's appIds

[GitBox <gi...@apache.org>]

Radeity commented on code in PR #12197:
URL: https://github.com/apache/dolphinscheduler/pull/12197#discussion_r983187618


##########
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/utils/TaskExecutionCheckerUtils.java:
##########
@@ -75,14 +75,14 @@ public static void checkTenantExist(WorkerConfig workerConfig, TaskExecutionCont
     public static void createProcessLocalPathIfAbsent(TaskExecutionContext taskExecutionContext) throws TaskException {
         try {
             // local execute path
-            String execLocalPath = FileUtils.getProcessExecDir(
-                    taskExecutionContext.getProjectCode(),
-                    taskExecutionContext.getProcessDefineCode(),
-                    taskExecutionContext.getProcessDefineVersion(),
-                    taskExecutionContext.getProcessInstanceId(),
-                    taskExecutionContext.getTaskInstanceId());
-            taskExecutionContext.setExecutePath(execLocalPath);
-            FileUtils.createWorkDirIfAbsent(execLocalPath);
+            // String execLocalPath = FileUtils.getProcessExecDir(
+            // taskExecutionContext.getProjectCode(),
+            // taskExecutionContext.getProcessDefineCode(),
+            // taskExecutionContext.getProcessDefineVersion(),
+            // taskExecutionContext.getProcessInstanceId(),
+            // taskExecutionContext.getTaskInstanbu iceId());
+            // taskExecutionContext.setExecutePath(execLocalPath);
+            FileUtils.createWorkDirIfAbsent(taskExecutionContext.getExecutePath());

Review Comment:
   > 
   
   I put it in `TaskExecutionContextBuilder` when setting some task related attribution, together with setting of `appInfoPath`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org