[jira] [Updated] (SOLR-6246) Core fails to reload when AnalyzingInfixSuggester is used as a Suggester

["Steve Rowe (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steve Rowe updated SOLR-6246:
-----------------------------
    Attachment: SOLR-6246-test.patch

Patch that adds a random dictionary with configurable size and new tests that use it: 

# A build/reload test for each of {{AnalyzingInfixSuggester}} and {{BlendedInfixSuggester}}.
# A test that starts building a suggester in the background then initiates a core reload.

All the tests fail now. The first two only fail 50% of the time, with the cause given in others' reports on this issue; I'm not sure why they don't fail all the time.  (My earlier report of the previous test patch passing may have been luck/insufficient trials?).  The reload-while-building test sometimes finishes building, and then fails like the other tests, but sometimes reload causes the suggester's index writer to be closed, which causes an exception to be thrown, interrupting the build process.

For some reason, the suggesters' sidecar indexes have {{write.lock}} files in them even after {{writer.close()}} is called.

> Core fails to reload when AnalyzingInfixSuggester is used as a Suggester
> ------------------------------------------------------------------------
>
>                 Key: SOLR-6246
>                 URL: https://issues.apache.org/jira/browse/SOLR-6246
>             Project: Solr
>          Issue Type: Sub-task
>          Components: SearchComponents - other
>    Affects Versions: 4.8, 4.8.1, 4.9, 5.0, 5.1, 5.2, 5.3, 5.4
>            Reporter: Varun Thacker
>         Attachments: SOLR-6246.patch, SOLR-6246-test.patch, SOLR-6246-test.patch, SOLR-6246-test.patch, SOLR-6246-test.patch
>
>
> LUCENE-5477 - added near-real-time suggest building to AnalyzingInfixSuggester. One of the changes that went in was a writer is persisted now to support real time updates via the add() and update() methods.
> When we call Solr's reload command, a new instance of AnalyzingInfixSuggester is created. When trying to create a new writer on the same Directory a lock cannot be obtained and Solr fails to reload the core.
> Also when AnalyzingInfixLookupFactory throws a RuntimeException we should pass along the original message.
> I am not sure what should be the approach to fix it. Should we have a reloadHook where we close the writer?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org