You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2018/07/25 23:50:43 UTC

Review Request 68050: WIP: Refactored allocator performance benchmarks.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68050/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-9103
    https://issues.apache.org/jira/browse/MESOS-9103


Repository: mesos


Description
-------

WIP, still need to:
- Refactor the remaining tests;
- Add metrics summary;
- Improve some tests logic;
- Adjust test parameters to shorten test runtime.


Diffs
-----

  src/tests/hierarchical_allocator_tests.cpp 27fbd9cf0c4442e7675362a806d35bad141ffb6d 


Diff: https://reviews.apache.org/r/68050/diff/1/


Testing
-------

./bin/mesos-tests.sh --gtest_filter=*AddAndUpdateSlave* --benchmark
./bin/mesos-tests.sh --gtest_filter=*HierarchicalAllocations_BENCHMARK_Test.PersistentVolumes* --benchmark


Thanks,

Meng Zhu


Re: Review Request 68050: WIP: Refactored allocator performance benchmarks.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68050/#review206549
-----------------------------------------------------------



Patch looks great!

Reviews applied: [68049, 68050]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On July 25, 2018, 11:50 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68050/
> -----------------------------------------------------------
> 
> (Updated July 25, 2018, 11:50 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9103
>     https://issues.apache.org/jira/browse/MESOS-9103
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> WIP, still need to:
> - Refactor the remaining tests;
> - Add metrics summary;
> - Improve some tests logic;
> - Adjust test parameters to shorten test runtime.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp 27fbd9cf0c4442e7675362a806d35bad141ffb6d 
> 
> 
> Diff: https://reviews.apache.org/r/68050/diff/1/
> 
> 
> Testing
> -------
> 
> ./bin/mesos-tests.sh --gtest_filter=*AddAndUpdateSlave* --benchmark
> ./bin/mesos-tests.sh --gtest_filter=*HierarchicalAllocations_BENCHMARK_Test.PersistentVolumes* --benchmark
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Re: Review Request 68050: WIP: Refactored allocator performance benchmarks.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68050/#review206488
-----------------------------------------------------------



PASS: Mesos patch 68050 was successfully built and tested.

Reviews applied: `['68049', '68050']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1983/mesos-review-68050

- Mesos Reviewbot Windows


On July 25, 2018, 11:50 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68050/
> -----------------------------------------------------------
> 
> (Updated July 25, 2018, 11:50 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9103
>     https://issues.apache.org/jira/browse/MESOS-9103
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> WIP, still need to:
> - Refactor the remaining tests;
> - Add metrics summary;
> - Improve some tests logic;
> - Adjust test parameters to shorten test runtime.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp 27fbd9cf0c4442e7675362a806d35bad141ffb6d 
> 
> 
> Diff: https://reviews.apache.org/r/68050/diff/1/
> 
> 
> Testing
> -------
> 
> ./bin/mesos-tests.sh --gtest_filter=*AddAndUpdateSlave* --benchmark
> ./bin/mesos-tests.sh --gtest_filter=*HierarchicalAllocations_BENCHMARK_Test.PersistentVolumes* --benchmark
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>