[GitHub] [cassandra] bereng commented on a change in pull request #1314: CASSANDRA-17072-4.0: Fix ignored client warnings in DebuggableThreadPoolExecutor

[GitBox <gi...@apache.org>]

bereng commented on a change in pull request #1314:
URL: https://github.com/apache/cassandra/pull/1314#discussion_r747267457



##########
File path: src/java/org/apache/cassandra/cql3/statements/schema/CreateKeyspaceStatement.java
##########
@@ -87,10 +83,6 @@ public Keyspaces apply(Keyspaces schema)
         keyspace.params.validate(keyspaceName);
         Keyspaces keyspaces = schema.withAddedOrUpdated(keyspace);
 
-        int newNumWarnings = ClientWarn.instance.numWarnings();
-        if (newNumWarnings > previousNumWarnings)
-            clientWarnings.addAll(ClientWarn.instance.getWarnings().subList(previousNumWarnings, newNumWarnings));
-

Review comment:
       We're not ignoring warnings, but adding just the _newly generated ones_. Otherwise they would accumulate and duplicate depending on how state and multi-threading played at each particular scenario.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org