You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org> on 2011/10/29 23:21:33 UTC
[jira] [Commented] (SHINDIG-1653) Add callback function to print
timing information for gadget preloading.
[ https://issues.apache.org/jira/browse/SHINDIG-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139448#comment-13139448 ]
jiraposter@reviews.apache.org commented on SHINDIG-1653:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2616/
-----------------------------------------------------------
Review request for shindig.
Summary
-------
We already have a callback function for navigating gadgets in the common container which can be used to print timing information. Problem is if you preload the gadget before navigating the timing information during navigation is 0. It would be helpful to print timing information for preloading as well.
This addresses bug SHINDIG-1653.
https://issues.apache.org/jira/browse/SHINDIG-1653
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/assembler.js 1190425
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js 1190425
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/constant.js 1190425
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1190425
Diff: https://reviews.apache.org/r/2616/diff
Testing
-------
Modified sample container to log this information.
Thanks,
Ryan
> Add callback function to print timing information for gadget preloading.
> ------------------------------------------------------------------------
>
> Key: SHINDIG-1653
> URL: https://issues.apache.org/jira/browse/SHINDIG-1653
> Project: Shindig
> Issue Type: Improvement
> Affects Versions: 3.0.0
> Reporter: Ryan Baxter
> Priority: Minor
> Original Estimate: 3h
> Remaining Estimate: 3h
>
> We already have a callback function for navigating gadgets in the common container which can be used to print timing information. Problem is if you preload the gadget before navigating the timing information during navigation is 0. It would be helpful to print timing information for preloading as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira