You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/05/07 06:45:38 UTC
[GitHub] [incubator-seatunnel] legendtkl opened a new pull request, #1815: [Bugfix][seatunnel-core-flink] fix flink sql conf parse exception
legendtkl opened a new pull request, #1815:
URL: https://github.com/apache/incubator-seatunnel/pull/1815
## Purpose of this pull request
fix https://github.com/apache/incubator-seatunnel/issues/1814
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] legendtkl commented on pull request #1815: [Bugfix][seatunnel-core-flink] fix flink sql conf parse exception
Posted by GitBox <gi...@apache.org>.
legendtkl commented on PR #1815:
URL: https://github.com/apache/incubator-seatunnel/pull/1815#issuecomment-1120174578
> Hi @legendtkl, we can remove `CommandLineUtils#parseFlinkArgs` in this patch.
Removed. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] legendtkl commented on pull request #1815: [Bugfix][seatunnel-core-flink] fix flink sql conf parse exception
Posted by GitBox <gi...@apache.org>.
legendtkl commented on PR #1815:
URL: https://github.com/apache/incubator-seatunnel/pull/1815#issuecomment-1120153917
Hi, @ruanwenjun , would you help review this tiny PR when you'r free?
Thanks,
Kelu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun commented on a diff in pull request #1815: [Bugfix][seatunnel-core-flink] fix flink sql conf parse exception
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on code in PR #1815:
URL: https://github.com/apache/incubator-seatunnel/pull/1815#discussion_r867322691
##########
seatunnel-core/seatunnel-core-flink/src/test/java/org/apache/seatunnel/core/flink/utils/CommandLineUtilsTest.java:
##########
@@ -72,7 +73,15 @@ public void testBuildFlinkCommand() throws FileNotFoundException {
"-r", "run-application", "--unkown", "unkown-command"};
Assert.assertThrows(FileNotFoundException.class, () -> {
- CommandLineUtils.buildFlinkCommand(CommandLineUtils.parseCommandArgs(args1, FlinkJobType.SQL), "CLASS_NAME", "/path/to/jar");
+ CommandLineUtils.buildFlinkCommand(CommandLineUtils.parseCommandArgs(args1, FlinkJobType.SQL), "CLASS_NAME", "/path/to/jar", FlinkJobType.JAR);
});
+
+ String[] args2 = {"--detached", "-c", SQL_CONF_PATH, "-t", "-i", "city=shenyang", "-i", "date=20200202",
+ "-r", "run-application", "--unkown", "unkown-command"};
+ flinkCommandArgs = CommandLineUtils.parseCommandArgs(args2, FlinkJobType.SQL);
+ commands = CommandLineUtils.buildFlinkCommand(flinkCommandArgs, "CLASS_NAME", "/path/to/jar", FlinkJobType.SQL);
+ Assert.assertEquals(commands,
+ Arrays.asList("${FLINK_HOME}/bin/flink", "run-application", "--detached", "--unkown", "unkown-command", "-c",
+ "CLASS_NAME", "/path/to/jar", "--config", SQL_CONF_PATH, "--check", "-Dcity=shenyang", "-Ddate=20200202"));
Review Comment:
Suggest to split this test method, you can change this test method to `testBuildFlinkJarCommand` add another method `testBuildFlinkSqlCommand` or a better name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] legendtkl commented on pull request #1815: [Bugfix][seatunnel-core-flink] fix flink sql conf parse exception
Posted by GitBox <gi...@apache.org>.
legendtkl commented on PR #1815:
URL: https://github.com/apache/incubator-seatunnel/pull/1815#issuecomment-1120212956
Hi, @ruanwenjun @leo65535 , would you help merge this PR ? My next work rely on this.
Thanks,
Kelu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun merged pull request #1815: [Bugfix][seatunnel-core-flink] fix flink sql conf parse exception
Posted by GitBox <gi...@apache.org>.
ruanwenjun merged PR #1815:
URL: https://github.com/apache/incubator-seatunnel/pull/1815
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on pull request #1815: [Bugfix][seatunnel-core-flink] fix flink sql conf parse exception
Posted by GitBox <gi...@apache.org>.
leo65535 commented on PR #1815:
URL: https://github.com/apache/incubator-seatunnel/pull/1815#issuecomment-1120171099
Hi @legendtkl, we can remove `CommandLineUtils#parseFlinkArgs` in this patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org