You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/08/26 09:08:45 UTC
[GitHub] [apisix] wayne-cheng commented on a change in pull request #4881: fix: validation during merging node_listen configuration
wayne-cheng commented on a change in pull request #4881:
URL: https://github.com/apache/apisix/pull/4881#discussion_r696442141
##########
File path: apisix/cli/file.lua
##########
@@ -112,6 +112,28 @@ local function tinyyaml_type(t)
end
+local function path_is_multi_type(path, type_val)
+ if str_sub(path, 1, 14) == "nginx_config->" and
+ (type_val == "number" or type_val == "string") then
+ return true
+ end
+
+ if path == "apisix->node_listen" and type_val == "number" then
+ return true
+ end
+
+ if path == "apisix->ssl->listen_port" and type_val == "number" then
+ return true
+ end
+
+ if path == "apisix->ssl->listen" and type_val == "number" then
Review comment:
@tzssangglass The config `apisix.ssl.listen` will be used in another PR (#4856). This will not affect the current code, do I remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org