[thrift] branch master updated: THRIFT-4915 Deserializing double into OrderedFloat always returns zero when using TCompactProtocol Documentation fix Patch: Jens Geyer

[je...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

jensg pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/thrift.git


The following commit(s) were added to refs/heads/master by this push:
     new 450bc69  THRIFT-4915 Deserializing double into OrderedFloat always returns zero when using TCompactProtocol Documentation fix Patch: Jens Geyer
450bc69 is described below

commit 450bc69248043f0ea5ca336d786583ebf3e9d826
Author: Jens Geyer <je...@apache.org>
AuthorDate: Tue Dec 3 23:28:03 2019 +0100

    THRIFT-4915 Deserializing double into OrderedFloat always returns zero when using TCompactProtocol
    Documentation fix
    Patch: Jens Geyer
---
 doc/specs/thrift-compact-protocol.md | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/doc/specs/thrift-compact-protocol.md b/doc/specs/thrift-compact-protocol.md
index 02467dd..6be2a62 100644
--- a/doc/specs/thrift-compact-protocol.md
+++ b/doc/specs/thrift-compact-protocol.md
@@ -97,8 +97,9 @@ Where:
 ### Double encoding
 
 Values of type `double` are first converted to an int64 according to the IEEE 754 floating-point "double format" bit
-layout. Most run-times provide a library to make this conversion. Both the binary protocol as the compact protocol then
-encode the int64 in 8 bytes in big endian order.
+layout. Most run-times provide a library to make this conversion. But while the binary protocol encodes the int64 
+in 8 bytes in big endian order, the compact protocol encodes it in little endian order - this is due to an early 
+implementation bug that finally became the de-facto standard.
 
 ### Boolean encoding