[jira] [Commented] (AIRFLOW-3014) Password column on connection table should be longer

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-3014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16723729#comment-16723729 ] 

ASF GitHub Bot commented on AIRFLOW-3014:
-----------------------------------------

stale[bot] closed pull request #3851: AIRFLOW-3014 Increase possible length of passwords in connection table
URL: https://github.com/apache/incubator-airflow/pull/3851
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/airflow/migrations/versions/5bb129a06791_allow_longer_passwords.py b/airflow/migrations/versions/5bb129a06791_allow_longer_passwords.py
new file mode 100644
index 0000000000..0a9ad01aaa
--- /dev/null
+++ b/airflow/migrations/versions/5bb129a06791_allow_longer_passwords.py
@@ -0,0 +1,44 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+"""Increase length of password column in connection table
+
+Revision ID: 5bb129a06791
+Revises: dd25f486b8ea
+Create Date: 2018-09-05 09:07:19.143887
+
+"""
+from alembic import op
+import sqlalchemy as sa
+
+# revision identifiers, used by Alembic.
+revision = '5bb129a06791'
+down_revision = 'dd25f486b8ea'
+branch_labels = None
+depends_on = None
+
+
+def upgrade():
+    op.alter_column(table_name='connection',
+                    column_name='password',
+                    type_=sa.String(length=5000))
+
+
+def downgrade():
+    # This migration cannot be undone
+    pass


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Password column on connection table should be longer
> ----------------------------------------------------
>
>                 Key: AIRFLOW-3014
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3014
>             Project: Apache Airflow
>          Issue Type: Improvement
>            Reporter: Brian Campbell
>            Priority: Minor
>
> The password column in the connection table has a maximum length of 500 characters. In some cases this is insufficient. For example, AWS provides passwords for ECR that, when encrypted, are longer than 3400 characters. In order to use the docker operator with ECR, you will need a longer password column on the connection table.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)