svn commit: r660178 - /lucene/solr/trunk/src/java/org/apache/solr/handler/RequestHandlerBase.java

[ot...@apache.org]

Author: otis
Date: Mon May 26 05:51:03 2008
New Revision: 660178

URL: http://svn.apache.org/viewvc?rev=660178&view=rev
Log:
- Added back a TODO per Yonik's request

Modified:
    lucene/solr/trunk/src/java/org/apache/solr/handler/RequestHandlerBase.java

Modified: lucene/solr/trunk/src/java/org/apache/solr/handler/RequestHandlerBase.java
URL: http://svn.apache.org/viewvc/lucene/solr/trunk/src/java/org/apache/solr/handler/RequestHandlerBase.java?rev=660178&r1=660177&r2=660178&view=diff
==============================================================================
--- lucene/solr/trunk/src/java/org/apache/solr/handler/RequestHandlerBase.java (original)
+++ lucene/solr/trunk/src/java/org/apache/solr/handler/RequestHandlerBase.java Mon May 26 05:51:03 2008
@@ -37,13 +37,15 @@
 public abstract class RequestHandlerBase implements SolrRequestHandler, SolrInfoMBean {
 
   // statistics
+  // TODO: should we bother synchronizing these, or is an off-by-one error
+  // acceptable every million requests or so?
   volatile long numRequests;
   volatile long numErrors;
-  volatile long totalTime = 0;
   protected NamedList initArgs = null;
   protected SolrParams defaults;
   protected SolrParams appends;
   protected SolrParams invariants;
+  volatile long totalTime = 0;
   long handlerStart = System.currentTimeMillis();
 
   /** shorten the class references for utilities */
@@ -106,7 +108,7 @@
       o = args.get("invariants");
       if (o != null && o instanceof NamedList) {
         invariants = SolrParams.toSolrParams((NamedList)o);
-      } 
+      }
     }
   }