You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/05/17 17:32:46 UTC

[GitHub] [echarts] 100pah opened a new pull request #14972: fix: When component `tooltip.formatter` is not specified, use a specific default formatter, rather than use global `tooltip.formatter` as default.

100pah opened a new pull request #14972:
URL: https://github.com/apache/echarts/pull/14972


   fix: When component `tooltip.formatter` is not specified, use a specific default formatter, rather than use global `tooltip.formatter` as default. 
   
   That because the global `tooltip.formatter` is usually configured for series. But tooltip formatter usually can not be shared by series and components (they have different params). So the global `tooltip.formatter` is usually not applicable for component.
   
   This PR make a specific default tooltip formatter for component, which return the item name.
   
   
   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   test case: test/tooltip-component.html (the last case).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #14972: fix: When component `tooltip.formatter` is not specified, use a specific default formatter, rather than use global `tooltip.formatter` as default.

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #14972:
URL: https://github.com/apache/echarts/pull/14972#issuecomment-842504972


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
   
   The pull request is marked to be `PR: author is committer` because you are a committer of this project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #14972: fix: When component `tooltip.formatter` is not specified, use a specific default formatter, rather than use global `tooltip.formatter` as default.

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #14972:
URL: https://github.com/apache/echarts/pull/14972#issuecomment-842504972


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
   
   The pull request is marked to be `PR: author is committer` because you are a committer of this project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #14972: fix: When component `tooltip.formatter` is not specified, use a specific default formatter, rather than use global `tooltip.formatter` as default. Fix #14939

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #14972:
URL: https://github.com/apache/echarts/pull/14972#issuecomment-842778980


   Congratulations! Your PR has been merged. Thanks for your contribution! 👍


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] pissang merged pull request #14972: fix: When component `tooltip.formatter` is not specified, use a specific default formatter, rather than use global `tooltip.formatter` as default. Fix #14939

Posted by GitBox <gi...@apache.org>.
pissang merged pull request #14972:
URL: https://github.com/apache/echarts/pull/14972


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org