You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2025/12/19 01:11:59 UTC
[PR] docs: federate scattered markdown files into centralized docs [superset]
rusackas opened a new pull request, #36756:
URL: https://github.com/apache/superset/pull/36756
## Summary
This PR consolidates scattered markdown documentation files from the repository root into the centralized Docusaurus docs site, establishing a single source of truth and eliminating duplicated/outdated content.
### Changes
**1. CONTRIBUTING.md → Developer Portal redirect**
- Converted to a minimal redirect stub pointing to the docs site
- Updated 14 files that linked to CONTRIBUTING.md
**2. INSTALL.md → Installation docs redirect**
- Converted to redirect stub pointing to installation docs
**3. UPDATING.md → Linked from upgrade docs**
- Kept as active changelog (part of release process)
- Added link from docs/installation/upgrading-superset.mdx
**4. Linting docs consolidated**
- Merged LINTING_ARCHITECTURE.md + superset-frontend/LINTING.md → developer_portal/howtos.md
- Deleted both standalone files
- Updated references to OXC (replacing ESLint)
**5. Playwright README consolidated**
- Moved superset-frontend/playwright/README.md → developer_portal/testing/e2e-testing.md
- Deleted standalone README
**6. FEATURE_FLAGS.md → Dynamic docs page** ⭐
- Annotated feature flags in `superset/config.py` with `@lifecycle`, `@docs`, `@category`
- Created `scripts/extract_feature_flags.py` parser to extract metadata to JSON
- Created `docs/docs/configuration/feature-flags.mdx` that dynamically renders the JSON
- Deleted `RESOURCES/FEATURE_FLAGS.md`
- Updated all references (10 files)
### Benefits
- **Single source of truth**: Documentation lives in one place
- **Auto-generated feature flags**: Docs stay in sync with code annotations
- **Reduced maintenance**: No need to update multiple files
- **Better discoverability**: Users find docs in one consistent location
## Test Plan
- [ ] Verify docs site builds: `cd docs && npm run build`
- [ ] Check feature flags page renders correctly
- [ ] Verify all updated links work
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs: federate scattered markdown files into centralized docs [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #36756:
URL: https://github.com/apache/superset/pull/36756#issuecomment-3716559986
### <span aria-hidden="true">👷</span> Deploy Preview for *superset-docs-preview* processing.
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | de0bb73b56c0ea58b4cf6a324bfb54f3004320e1 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/695d8891d659480008d125e0 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs: federate scattered markdown files into centralized docs [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #36756:
URL: https://github.com/apache/superset/pull/36756#issuecomment-3771139247
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs: federate scattered markdown files into centralized docs [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #36756:
URL: https://github.com/apache/superset/pull/36756#discussion_r2633216321
##########
scripts/extract_feature_flags.py:
##########
@@ -0,0 +1,194 @@
+#!/usr/bin/env python3
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""
+Extract feature flag metadata from superset/config.py.
+
+This script parses the annotated feature flags in config.py and outputs
+a JSON file that can be consumed by the documentation site to generate
+dynamic feature flag tables.
+
+Usage:
+ python scripts/extract_feature_flags.py > docs/static/feature-flags.json
+
+Annotations supported:
+ @lifecycle: development | testing | stable | deprecated
+ @docs: URL to documentation
+ @category: runtime_config | path_to_deprecation | internal (for stable flags)
+"""
+
+import json
+import re
+import sys
+from pathlib import Path
+from typing import TypedDict
+
+
+class FeatureFlag(TypedDict, total=False):
+ name: str
+ default: bool
+ lifecycle: str
+ description: str
+ docs: str | None
+ category: str | None
+
+
+def extract_feature_flags(config_path: Path) -> list[FeatureFlag]:
+ """
+ Parse config.py and extract feature flag metadata from comments.
+
+ Each flag should have a comment block above it with:
+ - Description (first line(s) before @annotations)
+ - @lifecycle: development | testing | stable | deprecated
+ - @docs: URL (optional)
+ - @category: runtime_config | path_to_deprecation | internal (optional)
+ """
+ content = config_path.read_text()
+
+ # Find the DEFAULT_FEATURE_FLAGS dict
+ match = re.search(
+ r"DEFAULT_FEATURE_FLAGS:\s*dict\[str,\s*bool\]\s*=\s*\{(.+?)\n\}",
Review Comment:
**Suggestion:** The regex used to locate `DEFAULT_FEATURE_FLAGS` is tightly coupled to the exact type annotation `dict[str, bool]`, so if the annotation is ever changed (e.g. to `Dict[str, bool]`, a different mapping type, or removed), the script will fail to find the block and exit with an error, breaking feature flag docs generation. Relaxing the pattern to treat the type annotation as optional makes the script resilient to harmless annotation changes. [logic error]
**Severity Level:** Minor ⚠️
```suggestion
r"DEFAULT_FEATURE_FLAGS\s*(?::\s*dict\[str,\s*bool\])?\s*=\s*\{(.+?)\n\}",
```
<details>
<summary><b>Why it matters? ⭐ </b></summary>
The current regex requires the exact annotation " : dict[str, bool] " to be present. That's brittle — if the annotation is removed, capitalized (Dict), or changed slightly the search will fail and the script will exit with an error. Making the annotation optional in the pattern (as proposed) fixes a real fragility in the script and improves resilience of docs generation. The proposed change directly addresses the failure mode described and is a safe improvement.
</details>
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** scripts/extract_feature_flags.py
**Line:** 64:64
**Comment:**
*Logic Error: The regex used to locate `DEFAULT_FEATURE_FLAGS` is tightly coupled to the exact type annotation `dict[str, bool]`, so if the annotation is ever changed (e.g. to `Dict[str, bool]`, a different mapping type, or removed), the script will fail to find the block and exit with an error, breaking feature flag docs generation. Relaxing the pattern to treat the type annotation as optional makes the script resilient to harmless annotation changes.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs: federate scattered markdown files into centralized docs [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #36756:
URL: https://github.com/apache/superset/pull/36756#issuecomment-3774048585
CodeAnt AI is running Incremental review
---
### Thanks for using CodeAnt! 🎉
We're free for open-source projects. if you're enjoying it, help us grow by sharing.
[Share on X](https://twitter.com/intent/tweet?text=Just%20tried%20%40CodeAntAI%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A&url=https%3A//codeant.ai) ·
[Reddit](https://www.reddit.com/submit?title=Check%20out%20CodeAnt%20for%20automated%20code%20review&text=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A%20https%3A//codeant.ai) ·
[LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcodeant.ai&mini=true&title=Check%20out%20CodeAnt%20for%20automated%20code%20review&summary=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs: federate scattered markdown files into centralized docs [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #36756:
URL: https://github.com/apache/superset/pull/36756#issuecomment-3716696389
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs: federate scattered markdown files into centralized docs [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #36756:
URL: https://github.com/apache/superset/pull/36756#issuecomment-3780783412
CodeAnt AI Incremental review completed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs: federate scattered markdown files into centralized docs [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #36756:
URL: https://github.com/apache/superset/pull/36756#issuecomment-3673003636
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs: federate scattered markdown files into centralized docs [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #36756:
URL: https://github.com/apache/superset/pull/36756#issuecomment-3771014227
## **Sequence Diagram**
The PR adds annotations to superset/config.py and a small extractor script that parses those annotations into docs/static/feature-flags.json, which the Docusaurus feature-flags.mdx page imports to render a live feature‑flags table. This diagram shows the core generation → render path introduced by the PR.
```mermaid
sequenceDiagram
participant Dev/CI
participant Config as superset/config.py
participant Script as scripts/extract_feature_flags.py
participant Docs as Docusaurus (feature-flags.mdx)
participant User
Dev/CI->>Config: Annotate feature flags with @lifecycle/@docs/@category
Dev/CI->>Script: Run extractor during docs build
Script->>Config: Read & parse annotated DEFAULT_FEATURE_FLAGS
Script-->>Docs: Write docs/static/feature-flags.json
Docs->>Docs: Import JSON and render Feature Flags table
User->>Docs: View rendered Feature Flags page
```
---
*Generated by [CodeAnt AI](https://codeant.ai)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs: federate scattered markdown files into centralized docs [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #36756:
URL: https://github.com/apache/superset/pull/36756#issuecomment-3673011220
## Nitpicks 🔍
<table>
<tr><td>🔒 <strong>No security issues identified</strong></td></tr>
<tr><td>⚡ <strong>Recommended areas for review</strong><br><br>
- [ ] <a href='https://github.com/apache/superset/pull/36756/files#diff-c99ae4b2b09b756ab2189a99a9685229f9d12633fc2616c368ea869770f603bfR538-R780'><strong>Missing Runtime Validation</strong></a><br>The new flags are declared as a plain dict with many values. There is no runtime validation of key names or value types; typos or non-boolean values may silently cause incorrect behavior. Add checks to fail-fast during startup if values are invalid.<br>
- [ ] <a href='https://github.com/apache/superset/pull/36756/files#diff-c0572d70185f0d91aea4df42841fcbb06ce801baa65cb0582833b144c01b393fR63-R67'><strong>Fragile DEFAULT_FEATURE_FLAGS detection</strong></a><br>The regex used to locate the DEFAULT_FEATURE_FLAGS dict is brittle: it requires an exact type annotation spelling and a particular placement of the closing brace. Variations (no type annotation, single quotes, different spacing/line breaks, nested braces or trailing comma on the same line) will cause the script to fail to locate the dict and exit. Consider a more robust approach (brace counting or AST-based extraction) to reliably find the dict contents.<br>
- [ ] <a href='https://github.com/apache/superset/pull/36756/files#diff-c0572d70185f0d91aea4df42841fcbb06ce801baa65cb0582833b144c01b393fR99-R103'><strong>Fragile flag key/value parsing</strong></a><br>The flag detection regex only accepts double-quoted uppercase keys and exact True/False tokens on the same form. If keys use single quotes, lowercase, additional whitespace, inline comments, or there are trailing commas/formatting differences, flags may not be detected. Make the key/value pattern more flexible.<br>
- [ ] <a href='https://github.com/apache/superset/pull/36756/files#diff-c99ae4b2b09b756ab2189a99a9685229f9d12633fc2616c368ea869770f603bfR538-R780'><strong>Large Feature Flags Block</strong></a><br>The PR adds a very large inline DEFAULT_FEATURE_FLAGS dict. This increases maintenance burden and risks drift between code and docs/feature extraction tooling. Validate any consumers that assume presence/absence of specific keys and ensure downstream code isn't broken by reordering/renaming.<br>
- [ ] <a href='https://github.com/apache/superset/pull/36756/files#diff-f81fd8a91255770aa68d662a21840c2c0ee9996e2b136c74177ff7e7db841e49R26-R28'><strong>External Link Safety</strong></a><br>Anchor tags are rendered from the `flag.docs` value coming from JSON. If the value is an external URL, consider adding `target="_blank"` plus `rel="noopener noreferrer"`, and/or validate the URL scheme to avoid unsafe/relative redirects or inadvertent navigation behavior.<br>
</td></tr>
</table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs: federate scattered markdown files into centralized docs [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #36756:
URL: https://github.com/apache/superset/pull/36756#issuecomment-3771012157
CodeAnt AI is running Incremental review
---
### Thanks for using CodeAnt! 🎉
We're free for open-source projects. if you're enjoying it, help us grow by sharing.
[Share on X](https://twitter.com/intent/tweet?text=Just%20tried%20%40CodeAntAI%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A&url=https%3A//codeant.ai) ·
[Reddit](https://www.reddit.com/submit?title=Check%20out%20CodeAnt%20for%20automated%20code%20review&text=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A%20https%3A//codeant.ai) ·
[LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcodeant.ai&mini=true&title=Check%20out%20CodeAnt%20for%20automated%20code%20review&summary=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs: federate scattered markdown files into centralized docs [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #36756:
URL: https://github.com/apache/superset/pull/36756#issuecomment-3780779024
CodeAnt AI is running Incremental review
---
### Thanks for using CodeAnt! 🎉
We're free for open-source projects. if you're enjoying it, help us grow by sharing.
[Share on X](https://twitter.com/intent/tweet?text=Just%20tried%20%40CodeAntAI%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A&url=https%3A//codeant.ai) ·
[Reddit](https://www.reddit.com/submit?title=Check%20out%20CodeAnt%20for%20automated%20code%20review&text=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A%20https%3A//codeant.ai) ·
[LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcodeant.ai&mini=true&title=Check%20out%20CodeAnt%20for%20automated%20code%20review&summary=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs: federate scattered markdown files into centralized docs [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #36756:
URL: https://github.com/apache/superset/pull/36756#issuecomment-3716551781
CodeAnt AI is running Incremental review
---
### Thanks for using CodeAnt! 🎉
We're free for open-source projects. if you're enjoying it, help us grow by sharing.
[Share on X](https://twitter.com/intent/tweet?text=Just%20tried%20%40CodeAntAI%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A&url=https%3A//codeant.ai) ·
[Reddit](https://www.reddit.com/submit?title=Check%20out%20CodeAnt%20for%20automated%20code%20review&text=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A%20https%3A//codeant.ai) ·
[LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcodeant.ai&mini=true&title=Check%20out%20CodeAnt%20for%20automated%20code%20review&summary=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs: federate scattered markdown files into centralized docs [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #36756:
URL: https://github.com/apache/superset/pull/36756#issuecomment-3771014327
CodeAnt AI Incremental review completed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs: federate scattered markdown files into centralized docs [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #36756:
URL: https://github.com/apache/superset/pull/36756#issuecomment-3781047611
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs: federate scattered markdown files into centralized docs [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #36756:
URL: https://github.com/apache/superset/pull/36756
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs: federate scattered markdown files into centralized docs [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #36756:
URL: https://github.com/apache/superset/pull/36756#issuecomment-3673003504
CodeAnt AI is reviewing your PR.
---
### Thanks for using CodeAnt! 🎉
We're free for open-source projects. if you're enjoying it, help us grow by sharing.
[Share on X](https://twitter.com/intent/tweet?text=Just%20tried%20%40CodeAntAI%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A&url=https%3A//codeant.ai) ·
[Reddit](https://www.reddit.com/submit?title=Check%20out%20CodeAnt%20for%20automated%20code%20review&text=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A%20https%3A//codeant.ai) ·
[LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcodeant.ai&mini=true&title=Check%20out%20CodeAnt%20for%20automated%20code%20review&summary=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs: federate scattered markdown files into centralized docs [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #36756:
URL: https://github.com/apache/superset/pull/36756#issuecomment-3716831049
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs: federate scattered markdown files into centralized docs [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #36756:
URL: https://github.com/apache/superset/pull/36756#issuecomment-3774053618
CodeAnt AI Incremental review completed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs: federate scattered markdown files into centralized docs [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #36756:
URL: https://github.com/apache/superset/pull/36756#issuecomment-3774321559
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs: federate scattered markdown files into centralized docs [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on code in PR #36756:
URL: https://github.com/apache/superset/pull/36756#discussion_r2633224447
##########
docs/versioned_docs/version-6.0.0/configuration/configuring-superset.mdx:
##########
@@ -441,4 +441,4 @@ FEATURE_FLAGS = {
}
```
-A current list of feature flags can be found in [RESOURCES/FEATURE_FLAGS.md](https://github.com/apache/superset/blob/master/RESOURCES/FEATURE_FLAGS.md).
+A current list of feature flags can be found in the [Feature Flags](/docs/configuration/feature-flags) documentation.
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Versioned Docs Link Mismatch</b></div>
<div id="fix">
The link in this versioned documentation should point to the 6.0.0-specific feature flags list on GitHub, as the current internal link shows the latest feature flags which may not match the 6.0.0 release and could confuse users reading versioned docs.
</div>
</div>
<small><i>Code Review Run #b7602e</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/config.py:
##########
@@ -519,142 +519,264 @@ class D3TimeFormat(TypedDict, total=False):
# ---------------------------------------------------
# Feature flags
# ---------------------------------------------------
-# Feature flags that are set by default go here. Their values can be
-# overwritten by those specified under FEATURE_FLAGS in superset_config.py
-# For example, DEFAULT_FEATURE_FLAGS = { 'FOO': True, 'BAR': False } here
-# and FEATURE_FLAGS = { 'BAR': True, 'BAZ': True } in superset_config.py
-# will result in combined feature flags of { 'FOO': True, 'BAR': True, 'BAZ': True }
+# Feature flags control optional functionality in Superset. They can be set in
+# superset_config.py to override the defaults below.
+#
+# Example: FEATURE_FLAGS = { 'ALERT_REPORTS': True }
+#
+# Each flag is annotated with:
+# @lifecycle: development | testing | stable | deprecated
+# @docs: URL to documentation (optional)
+# @category: runtime_config | path_to_deprecation (for stable flags)
+#
+# Lifecycle meanings:
+# - development: Unfinished, for dev environments only
+# - testing: Complete but being validated, may have bugs
+# - stable: Production-ready, tested and supported
+# - deprecated: Will be removed in a future major release
+
DEFAULT_FEATURE_FLAGS: dict[str, bool] = {
- # When using a recent version of Druid that supports JOINs turn this on
- "DRUID_JOINS": False,
- "DYNAMIC_PLUGINS": False,
- "ENABLE_TEMPLATE_PROCESSING": False,
- # Allow for javascript controls components
- # this enables programmers to customize certain charts (like the
- # geospatial ones) by inputting javascript in controls. This exposes
- # an XSS security vulnerability
- "ENABLE_JAVASCRIPT_CONTROLS": False, # deprecated
+ # =================================================================
+ # IN DEVELOPMENT
+ # =================================================================
+ # These features are considered unfinished and should only be used
+ # on development environments.
+ # -----------------------------------------------------------------
+ # Enables Table V2 (AG Grid) viz plugin
+ # @lifecycle: development
+ "AG_GRID_TABLE_ENABLED": False,
+ # Enables experimental tabs UI for Alerts and Reports
+ # @lifecycle: development
+ "ALERT_REPORT_TABS": False,
+ # Enables experimental chart plugins
+ # @lifecycle: development
+ "CHART_PLUGINS_EXPERIMENTAL": False,
# Experimental PyArrow engine for CSV parsing (may have issues with dates/nulls)
+ # @lifecycle: development
"CSV_UPLOAD_PYARROW_ENGINE": False,
- # When this feature is enabled, nested types in Presto will be
- # expanded into extra columns and/or arrays. This is experimental,
- # and doesn't work with all nested types.
+ # Allow metrics and columns to be grouped into folders in the chart builder
+ # @lifecycle: development
+ "DATASET_FOLDERS": False,
+ # Enable support for date range timeshifts (e.g., "2015-01-03 : 2015-01-04")
+ # in addition to relative timeshifts (e.g., "1 day ago")
+ # @lifecycle: development
+ "DATE_RANGE_TIMESHIFTS_ENABLED": False,
+ # Enables advanced data type support
+ # @lifecycle: development
+ "ENABLE_ADVANCED_DATA_TYPES": False,
+ # Enable Superset extensions for custom functionality without modifying core
+ # @lifecycle: development
+ "ENABLE_EXTENSIONS": False,
+ # Enable Matrixify feature for matrix-style chart layouts
+ # @lifecycle: development
+ "MATRIXIFY": False,
+ # Try to optimize SQL queries — for now only predicate pushdown is supported
+ # @lifecycle: development
+ "OPTIMIZE_SQL": False,
+ # Expand nested types in Presto into extra columns/arrays. Experimental,
+ # doesn't work with all nested types.
+ # @lifecycle: development
"PRESTO_EXPAND_DATA": False,
- # Exposes API endpoint to compute thumbnails
- "THUMBNAILS": False,
- # Enables the endpoints to cache and retrieve dashboard screenshots via webdriver.
- # Requires configuring Celery and a cache using THUMBNAIL_CACHE_CONFIG.
- "ENABLE_DASHBOARD_SCREENSHOT_ENDPOINTS": False,
- # Generate screenshots (PDF or JPG) of dashboards using the web driver.
- # When disabled, screenshots are generated on the fly by the browser.
- # This feature flag is used by the download feature in the dashboard view.
- # It is dependent on ENABLE_DASHBOARD_SCREENSHOT_ENDPOINT being enabled.
- "ENABLE_DASHBOARD_DOWNLOAD_WEBDRIVER_SCREENSHOT": False,
+ # Enable Table V2 time comparison feature
+ # @lifecycle: development
+ "TABLE_V2_TIME_COMPARISON_ENABLED": False,
+ # Enables the tagging system for organizing assets
+ # @lifecycle: development
"TAGGING_SYSTEM": False,
- "SQLLAB_BACKEND_PERSISTENCE": True,
- "LISTVIEWS_DEFAULT_CARD_VIEW": False,
- # When True, this escapes HTML (rather than rendering it) in Markdown components
- "ESCAPE_MARKDOWN_HTML": False,
- "DASHBOARD_VIRTUALIZATION": True,
- # This feature flag is stil in beta and is not recommended for production use.
- "GLOBAL_ASYNC_QUERIES": False,
- "EMBEDDED_SUPERSET": False,
- # Enables Alerts and reports new implementation
- "ALERT_REPORTS": False,
- "ALERT_REPORT_TABS": False,
+ # =================================================================
+ # IN TESTING
+ # =================================================================
+ # These features are finished but currently being tested.
+ # They are usable, but may still contain some bugs.
+ # -----------------------------------------------------------------
+ # Enables filter functionality in Alerts and Reports
+ # @lifecycle: testing
"ALERT_REPORTS_FILTER": False,
+ # Enables Alerts and Reports functionality
+ # @lifecycle: testing
+ # @docs: https://superset.apache.org/docs/configuration/alerts-reports
+ "ALERT_REPORTS": False,
+ # Enables Slack V2 integration for Alerts and Reports
+ # @lifecycle: testing
"ALERT_REPORT_SLACK_V2": False,
- "DASHBOARD_RBAC": False,
- "ENABLE_ADVANCED_DATA_TYPES": False,
- # Enabling ALERTS_ATTACH_REPORTS, the system sends email and slack message
- # with screenshot and link
- # Disables ALERTS_ATTACH_REPORTS, the system DOES NOT generate screenshot
- # for report with type 'alert' and sends email and slack message with only link;
- # for report with type 'report' still send with email and slack message with
- # screenshot and link
- "ALERTS_ATTACH_REPORTS": True,
# Allow users to export full CSV of table viz type.
- # This could cause the server to run out of memory or compute.
+ # Warning: Could cause server memory/compute issues with large datasets.
+ # @lifecycle: testing
"ALLOW_FULL_CSV_EXPORT": False,
- "ALLOW_ADHOC_SUBQUERY": False,
- "USE_ANALOGOUS_COLORS": False,
- # Apply RLS rules to SQL Lab queries. This requires parsing and manipulating the
- # query, and might break queries and/or allow users to bypass RLS. Use with care!
- "RLS_IN_SQLLAB": False,
- # Try to optimize SQL queries — for now only predicate pushdown is supported.
- "OPTIMIZE_SQL": False,
- # When impersonating a user, use the email prefix instead of the username
- "IMPERSONATE_WITH_EMAIL_PREFIX": False,
- # Enable caching per impersonation key (e.g username) in a datasource where user
- # impersonation is enabled
+ # Enable caching per impersonation key in datasources with user impersonation
+ # @lifecycle: testing
"CACHE_IMPERSONATION": False,
- # Enable caching per user key for Superset cache (not database cache impersonation)
+ # Allow users to optionally specify date formats in email subjects
+ # @lifecycle: testing
+ # @docs: https://superset.apache.org/docs/configuration/alerts-reports
+ "DATE_FORMAT_IN_EMAIL_SUBJECT": False,
+ # Enable dynamic plugin loading
+ # @lifecycle: testing
+ "DYNAMIC_PLUGINS": False,
+ # Enables endpoints to cache and retrieve dashboard screenshots via webdriver.
+ # Requires Celery and THUMBNAIL_CACHE_CONFIG.
+ # @lifecycle: testing
+ "ENABLE_DASHBOARD_SCREENSHOT_ENDPOINTS": False,
+ # Generate screenshots (PDF/JPG) of dashboards using web driver.
+ # Depends on ENABLE_DASHBOARD_SCREENSHOT_ENDPOINTS.
+ # @lifecycle: testing
+ "ENABLE_DASHBOARD_DOWNLOAD_WEBDRIVER_SCREENSHOT": False,
+ # Allows users to add a superset:// DB that can query across databases.
+ # Experimental with potential security/performance risks. See SUPERSET_META_DB_LIMIT.
+ # @lifecycle: testing
+ # @docs: https://superset.apache.org/docs/configuration/databases/#querying-across-databases
+ "ENABLE_SUPERSET_META_DB": False,
+ # Enable query cost estimation. Supported in Presto, Postgres, and BigQuery.
+ # Requires `cost_estimate_enabled: true` in database `extra` attribute.
+ # @lifecycle: testing
+ "ESTIMATE_QUERY_COST": False,
+ # Enable async queries for dashboards and Explore via WebSocket.
+ # Requires Redis 5.0+ and Celery workers.
+ # @lifecycle: testing
+ # @docs: https://superset.apache.org/docs/contributing/misc#async-chart-queries
+ "GLOBAL_ASYNC_QUERIES": False,
+ # When impersonating a user, use the email prefix instead of username
+ # @lifecycle: testing
+ "IMPERSONATE_WITH_EMAIL_PREFIX": False,
+ # Replace Selenium with Playwright for reports and thumbnails.
+ # Supports deck.gl visualizations. Requires playwright pip package.
+ # @lifecycle: testing
+ "PLAYWRIGHT_REPORTS_AND_THUMBNAILS": False,
+ # Apply RLS rules to SQL Lab queries. Requires query parsing/manipulation.
+ # May break queries or allow RLS bypass. Use with care!
+ # @lifecycle: testing
+ "RLS_IN_SQLLAB": False,
+ # Allow users to enable SSH tunneling when creating a DB connection.
+ # DB engine must support SSH Tunnels.
+ # @lifecycle: testing
+ # @docs: https://superset.apache.org/docs/configuration/setup-ssh-tunneling
+ "SSH_TUNNELING": False,
+ # Use analogous colors in charts
+ # @lifecycle: testing
+ "USE_ANALOGOUS_COLORS": False,
+ # =================================================================
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Removes Used Feature Flags</b></div>
<div id="fix">
Removing these feature flags breaks existing functionality, as they are actively used in code (e.g., `is_feature_enabled("SLACK_ENABLE_AVATARS")` in `superset/views/users/api.py`). This will disable features like Slack avatars, CSS templates, dataset folders, and others, causing user-visible issues. Consider restoring them or refactoring the code to not depend on them.
</div>
</div>
<small><i>Code Review Run #b7602e</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] docs: federate scattered markdown files into centralized docs [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #36756:
URL: https://github.com/apache/superset/pull/36756#issuecomment-3673011339
CodeAnt AI finished reviewing your PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org