You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/26 10:19:16 UTC

[GitHub] [arrow] raulcd commented on a change in pull request #12265: MINOR: [Python][Packaging] Update crossbow cache key for vcpkg in the macos wheel builds

raulcd commented on a change in pull request #12265:
URL: https://github.com/apache/arrow/pull/12265#discussion_r792491601



##########
File path: dev/tasks/python-wheels/github.osx.amd64.yml
##########
@@ -55,7 +55,7 @@ jobs:
         id: vcpkg-cache
         with:
           path: vcpkg
-          key: vcpkg-{{ macos_deployment_target }}-{{ "${{ env.VCPKG_VERSION }}" }}-{{ "${{ hashFiles('arrow/ci/vcpkg/*.patch', 'arrow/ci/vcpkg/*osx*.cmake') }}" }}

Review comment:
       hi, I am new here, trying to learn :)
   Wouldn't adding the file to modify the hash be enough to generate the new key? Why are you adding the `-0`? Is there some process you expect would require to increment this number?
   The change looks good to me but just to understand why is the latter addition necessary




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org