[GitHub] [hbase] saintstack commented on a change in pull request #2797: HBASE-25425 Some notes on RawCell

[GitBox <gi...@apache.org>]

saintstack commented on a change in pull request #2797:
URL: https://github.com/apache/hbase/pull/2797#discussion_r546791732



##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java
##########
@@ -1000,25 +999,16 @@ public byte getTypeByte() {
 
     @Override
     public Optional<Tag> getTag(byte type) {
-      if (cell instanceof RawCell) {
-        return ((RawCell) cell).getTag(type);
-      }
       return PrivateCellUtil.getTag(cell, type);
     }
 
     @Override
     public Iterator<Tag> getTags() {
-      if (cell instanceof RawCell) {
-        return ((RawCell) cell).getTags();
-      }
       return PrivateCellUtil.tagsIterator(cell);
     }
 
     @Override
     public byte[] cloneTags() {
-      if (cell instanceof RawCell) {
-        return ((RawCell) cell).cloneTags();

Review comment:
       Yes.
   
   Trivial change. Just shrinking the use of RawCell so it more obvious it is only needed in one location. Its weird having RawCell out in the client module when internally it is just doing the PrivateCellUtil method anyways.
   
   I think this circumstance came about innocently after going back over git history... This was just not noticed before this.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org