You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@flink.apache.org by GitBox <gi...@apache.org> on 2022/02/22 05:26:00 UTC

[GitHub] [flink-kubernetes-operator] Aitozi commented on pull request #10: [FLINK-26290] Introduce serviceAccount as direct field, remove taskSlots

Aitozi commented on pull request #10:
URL: https://github.com/apache/flink-kubernetes-operator/pull/10#issuecomment-1047438031


   Hi @tweise I left one concern for this PR
   
   I think we should avoid to introduce option as first class field when there is already config in Flink have the same effect, It brings the proxy work and may make user confused. 
   
   As described in https://lists.apache.org/thread/3q5bmr9253opv5b122s9nokp8yqq5rmw
   > I agree with the sentiment that whenever possible we should use the native configuration directly (either Flink native settings or k8s pod template)
   
   So I think the `serviceAccount` can also reuse the `KubernetesConfigOptions#KUBERNETES_SERVICE_ACCOUNT` 
   `KubernetesConfigOptions#JOB_MANAGER_SERVICE_ACCOUNT` `KubernetesConfigOptions#TASK_MANAGER_SERVICE_ACCOUNT`. This can also work for the standalone mode. It can render the Pod template with the Flink effective configuration.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org