You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@issues.apache.org on 2010/05/26 00:25:07 UTC

[Bug 6122] [review] Mail::DKIM 0.34 removed DkimPolicy::as_string, which was used in dbg call

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6122

Kevin A. McGrail <km...@pccc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kmcgrail@pccc.com

--- Comment #5 from Kevin A. McGrail <km...@pccc.com> 2010-05-25 18:25:05 EDT ---
(In reply to comment #4)
> Thanks to Kevin for contacting the author of Mail::DKIM, the version 0.36
> has been published, making the missing Mail::DKIM::DkimPolicy::as_string
> available again. So the attached patch is only necessary for versions
> 0.34 and 0.35, but it does no harm to other versions (except for less
> informative log entry).
> 
> There are two choices now, go on with the patch, or require a 0.36+ .
> I'd still go with the patch, but the need for it is much reduced now.
> 
> My reason for dropping the logging of a policy is that this area
> of SSP/ADSP processing has been much revised, both in the IETF WG,
> in the Mail::DKIM plugin and in the version of DKIM Plugin in SA 3.3,
> so the code section we are discussing here will go away sooner or later.
> We are only discussing a quick fix here.

+1 to require 0.36+ of DKIM for 3.3.X next realease.  It's been almost a year
since this issue was resolved by the author of DKIM.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.