You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by "kusalk (via GitHub)" <gi...@apache.org> on 2023/03/03 11:52:37 UTC
[GitHub] [struts] kusalk opened a new pull request, #666: WW-5290 Refactor ConfigurationManager
kusalk opened a new pull request, #666:
URL: https://github.com/apache/struts/pull/666
WW-5290
--
Apart from improving the readability and maintainability of this class, this refactor fixes some logic issues and prevents improper use. It enforces thread safety and also improves performance, specifically on initialisation. We no longer do 2 reloads unnecessarily in certain scenarios.
I've additionally ran these changes through the Confluence DC test suite and everything is passing. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] [struts] kusalk commented on a diff in pull request #666: WW-5290 Refactor ConfigurationManager
Posted by "kusalk (via GitHub)" <gi...@apache.org>.
kusalk commented on code in PR #666:
URL: https://github.com/apache/struts/pull/666#discussion_r1124354941
##########
core/src/test/java/org/apache/struts2/dispatcher/DispatcherTest.java:
##########
@@ -287,9 +283,6 @@ public void testInterceptorDestroy() {
Mock mockContainer = new Mock(Container.class);
mockContainer.matchAndReturn("getInstance", C.args(C.eq(ObjectFactory.class)), new ObjectFactory());
- String reloadConfigs = container.getInstance(String.class, StrutsConstants.STRUTS_CONFIGURATION_XML_RELOAD);
- mockContainer.expectAndReturn("getInstance", C.args(C.eq(String.class), C.eq(StrutsConstants.STRUTS_CONFIGURATION_XML_RELOAD)),
Review Comment:
We no longer expect a 2nd reload in these tests as it was unnecessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [struts] lukaszlenart merged pull request #666: WW-5290 Refactor ConfigurationManager
Posted by "lukaszlenart (via GitHub)" <gi...@apache.org>.
lukaszlenart merged PR #666:
URL: https://github.com/apache/struts/pull/666
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org