You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org> on 2018/03/15 17:37:51 UTC
[native-toolchain-CR](cdh5.x) IMPALA-5717: Build ORC C++ lib in toolchain
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9657
Change subject: IMPALA-5717: Build ORC C++ lib in toolchain
......................................................................
IMPALA-5717: Build ORC C++ lib in toolchain
This adds the C++ library from the Apache ORC project. 1.4.3 is the
latest release at the time of writing.
Includes two patches:
* One that allows building ORC against our versions of dependencies.
ORC-266 fixes this upstream, but could not be cleanly cherry-picked.
* One that fixes a header that wasn't installed properly.
Testing:
Confirmed that it built locally, confirmed that the built utilities were
runnable after sourcing impala-config.sh.
Built on all supported distros.
Change-Id: I6abd86a5a683f19aa44b47629edf283b938b7e7e
---
M buildall.sh
A source/orc/build.sh
A source/orc/orc-1.4.3-patches/0001-Allow-building-against-external-versions-of-dependen.patch
A source/orc/orc-1.4.3-patches/0002-ORC-239.-Install-missing-Statistics.hh-header-file.patch
4 files changed, 224 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/57/9657/1
--
To view, visit http://gerrit.cloudera.org:8080/9657
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: cdh5.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6abd86a5a683f19aa44b47629edf283b938b7e7e
Gerrit-Change-Number: 9657
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[native-toolchain-CR](cdh5.x) IMPALA-5717: Build ORC C++ lib in toolchain
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9657 )
Change subject: IMPALA-5717: Build ORC C++ lib in toolchain
......................................................................
Patch Set 1: Code-Review+2
Clean cherry-pick
--
To view, visit http://gerrit.cloudera.org:8080/9657
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: cdh5.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I6abd86a5a683f19aa44b47629edf283b938b7e7e
Gerrit-Change-Number: 9657
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 15 Mar 2018 17:38:27 +0000
Gerrit-HasComments: No
[native-toolchain-CR](cdh5.x) IMPALA-5717: Build ORC C++ lib in toolchain
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9657 )
Change subject: IMPALA-5717: Build ORC C++ lib in toolchain
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/9657
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: cdh5.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I6abd86a5a683f19aa44b47629edf283b938b7e7e
Gerrit-Change-Number: 9657
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 15 Mar 2018 17:38:33 +0000
Gerrit-HasComments: No
[native-toolchain-CR](cdh5.x) IMPALA-5717: Build ORC C++ lib in toolchain
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9657 )
Change subject: IMPALA-5717: Build ORC C++ lib in toolchain
......................................................................
IMPALA-5717: Build ORC C++ lib in toolchain
This adds the C++ library from the Apache ORC project. 1.4.3 is the
latest release at the time of writing.
Includes two patches:
* One that allows building ORC against our versions of dependencies.
ORC-266 fixes this upstream, but could not be cleanly cherry-picked.
* One that fixes a header that wasn't installed properly.
Testing:
Confirmed that it built locally, confirmed that the built utilities were
runnable after sourcing impala-config.sh.
Built on all supported distros.
Change-Id: I6abd86a5a683f19aa44b47629edf283b938b7e7e
---
M buildall.sh
A source/orc/build.sh
A source/orc/orc-1.4.3-patches/0001-Allow-building-against-external-versions-of-dependen.patch
A source/orc/orc-1.4.3-patches/0002-ORC-239.-Install-missing-Statistics.hh-header-file.patch
4 files changed, 224 insertions(+), 0 deletions(-)
Approvals:
Thomas Tauber-Marshall: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/9657
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: cdh5.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I6abd86a5a683f19aa44b47629edf283b938b7e7e
Gerrit-Change-Number: 9657
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>