[jira] [Comment Edited] (IGNITE-12896) excludeNeighbors=true breaks zone-awareness

["Vyacheslav Koptilin (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-12896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083391#comment-17083391 ] 

Vyacheslav Koptilin edited comment on IGNITE-12896 at 4/14/20, 4:24 PM:
------------------------------------------------------------------------

Hello [~haizaar],

Yes, it seems the following pages should be updated:
  - provide comprehensive information about {{excludeNeighbors}} [https://apacheignite.readme.io/docs/affinity-collocation#section-affinity-function]
  - correct example [ClusterNodeAttributeAffinityBackupFilter|https://ignite.apache.org/releases/latest/javadoc/org/apache/ignite/cache/affinity/rendezvous/ClusterNodeAttributeAffinityBackupFilter.html]

By the way, {{RendezvousAffinityFunction}} clearly describes this aspect
{code:java}
/**
 * Sets optional backup filter.
 * ...
 * <p>
 * Note that {@code affinityBackupFilter} is ignored if {@code excludeNeighbors} is set to {@code true}.
 * ...
 */
public RendezvousAffinityFunction setAffinityBackupFilter(
    IgniteBiPredicate<ClusterNode, List<ClusterNode>> affinityBackupFilter) {...}

{code}


was (Author: slava.koptilin):
Hello [~haizaar],

Yes, it seems the following pages should be updated:
 - provide comprehensive information about {{excludeNeighbors}} [https://apacheignite.readme.io/docs/affinity-collocation#section-affinity-function]
 - correct example [ClusterNodeAttributeAffinityBackupFilter|[https://ignite.apache.org/releases/latest/javadoc/org/apache/ignite/cache/affinity/rendezvous/ClusterNodeAttributeAffinityBackupFilter.html]]

 

By the way, {{RendezvousAffinityFunction}} clearly describes this aspect
{code:java}
/**
 * Sets optional backup filter.
 * ...
 * <p>
 * Note that {@code affinityBackupFilter} is ignored if {@code excludeNeighbors} is set to {@code true}.
 * ...
 */
public RendezvousAffinityFunction setAffinityBackupFilter(
    IgniteBiPredicate<ClusterNode, List<ClusterNode>> affinityBackupFilter) {...}

{code}

> excludeNeighbors=true breaks zone-awareness
> -------------------------------------------
>
>                 Key: IGNITE-12896
>                 URL: https://issues.apache.org/jira/browse/IGNITE-12896
>             Project: Ignite
>          Issue Type: Bug
>          Components: cache
>    Affects Versions: 2.8
>            Reporter: Zaar Hai
>            Priority: Major
>
> Good day,
>  
> If I configure node config as in the official [example |[https://ignite.apache.org/releases/latest/javadoc/org/apache/ignite/cache/affinity/rendezvous/ClusterNodeAttributeAffinityBackupFilter.html]] but also set excludeNeighbors to true, then zone-aware partition distribution simply doesn't work. No errors or warnings that  found - it is just does not work. 
> From documentation it's not clear (at least to me) that excludeNeighbors=true has such a critical implication on zone-awareness info. From what is sounds, zone-awareness is an extension of excludeNeighbors.
> I think this behavour should be fixed or at least documented with big red signs. As it's now, it resulted in several days of my time batting with zone-aware setup.
> There are more details here in this StackOverflow question: [https://stackoverflow.com/questions/61062929/apache-ignite-zonerack-aware-parititons/61189356#61189356]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)