You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by sl...@apache.org on 2016/02/03 12:14:45 UTC
[02/10] cassandra git commit: Add comment on DateType explaining that
its kept only for backward compatibility
Add comment on DateType explaining that its kept only for backward compatibility
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/3ec7d8c0
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/3ec7d8c0
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/3ec7d8c0
Branch: refs/heads/cassandra-3.0
Commit: 3ec7d8c056c71b3032b1ca1d1fd07462c5091900
Parents: af2b858
Author: Sylvain Lebresne <sy...@datastax.com>
Authored: Wed Feb 3 12:08:13 2016 +0100
Committer: Sylvain Lebresne <sy...@datastax.com>
Committed: Wed Feb 3 12:08:13 2016 +0100
----------------------------------------------------------------------
src/java/org/apache/cassandra/db/marshal/DateType.java | 5 +++++
src/java/org/apache/cassandra/db/marshal/TimeType.java | 6 ------
2 files changed, 5 insertions(+), 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cassandra/blob/3ec7d8c0/src/java/org/apache/cassandra/db/marshal/DateType.java
----------------------------------------------------------------------
diff --git a/src/java/org/apache/cassandra/db/marshal/DateType.java b/src/java/org/apache/cassandra/db/marshal/DateType.java
index 82ed876..5186ca8 100644
--- a/src/java/org/apache/cassandra/db/marshal/DateType.java
+++ b/src/java/org/apache/cassandra/db/marshal/DateType.java
@@ -31,6 +31,11 @@ import org.apache.cassandra.serializers.TimestampSerializer;
import org.apache.cassandra.serializers.MarshalException;
import org.apache.cassandra.utils.ByteBufferUtil;
+/**
+ * This is the old version of TimestampType, but has been replaced as it wasn't comparing pre-epoch timestamps
+ * correctly. This is kept for backward compatibility but shouldn't be used in new code.
+ */
+@Deprecated
public class DateType extends AbstractType<Date>
{
private static final Logger logger = LoggerFactory.getLogger(DateType.class);
http://git-wip-us.apache.org/repos/asf/cassandra/blob/3ec7d8c0/src/java/org/apache/cassandra/db/marshal/TimeType.java
----------------------------------------------------------------------
diff --git a/src/java/org/apache/cassandra/db/marshal/TimeType.java b/src/java/org/apache/cassandra/db/marshal/TimeType.java
index c241a38..86de574 100644
--- a/src/java/org/apache/cassandra/db/marshal/TimeType.java
+++ b/src/java/org/apache/cassandra/db/marshal/TimeType.java
@@ -52,12 +52,6 @@ public class TimeType extends AbstractType<Long>
}
@Override
- public boolean isCompatibleWith(AbstractType<?> previous)
- {
- return super.isCompatibleWith(previous);
- }
-
- @Override
public boolean isValueCompatibleWithInternal(AbstractType<?> otherType)
{
return this == otherType || otherType == LongType.instance;