You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/08/23 04:56:41 UTC

[GitHub] [spark] HeartSaVioR commented on a change in pull request #25562: [SPARK-27330][SS] call foreach writer close on abort

HeartSaVioR commented on a change in pull request #25562: [SPARK-27330][SS] call foreach writer close on abort
URL: https://github.com/apache/spark/pull/25562#discussion_r316973836
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/ForeachWriterProvider.scala
 ##########
 @@ -112,6 +113,8 @@ class ForeachDataWriter[T](
 
   // If open returns false, we should skip writing rows.
   private val opened = writer.open(partitionId, epochId)
+  private var closeCalled: Boolean = false
+
 
 Review comment:
   nit: unnecessary newline

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org