[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #262: Unordered sequences

[GitBox <gi...@apache.org>]

mbeckerle commented on a change in pull request #262: Unordered sequences
URL: https://github.com/apache/incubator-daffodil/pull/262#discussion_r320362435
 
 

 ##########
 File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/SequenceParserBases.scala
 ##########
 @@ -44,6 +50,45 @@ abstract class SequenceParserBase(
   override lazy val childProcessors = childParsers
 }
 
+abstract class UnorderedSequenceParserBase(
+  srd: SequenceRuntimeData,
+  choiceParser: ChoiceParser)
+  extends SequenceParserBase(srd, Vector(choiceParser)) {
+
+  override protected def parse(pstate: PState) = {
+
+    var isDone = false
+
+    while (!isDone && (pstate.processorStatus eq Success)) {
 
 Review comment:
   If this loop is being used in the separated case, then this can't work because it can't handle separatorPosition="postfix". It has no way to decide to parse a choice child followed by a postfix separator because it is assuming the sep parser has been melded into the choiceParser. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services