You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/02/25 09:53:08 UTC
[GitHub] [incubator-nuttx-apps] anchao opened a new pull request #98:
net/wapi: remove unnecessary cast
anchao opened a new pull request #98: net/wapi: remove unnecessary cast
URL: https://github.com/apache/incubator-nuttx-apps/pull/98
Change-Id: I4f7e9a8e4b4f38f08bd0a1ede1994e24f80bf89b
Signed-off-by: chao.an <an...@xiaomi.com>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] Ouss4 commented on a change in pull request
#98: netutils: add support to save wapi config to file system
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #98: netutils: add support to save wapi config to file system
URL: https://github.com/apache/incubator-nuttx-apps/pull/98#discussion_r383844169
##########
File path: include/wireless/wapi.h
##########
@@ -95,6 +95,12 @@
# define SOCK_WAPI SOCK_STREAM
#endif
+#ifndef CONFIG_WIRELESS_WAPI_INITCONF
+#define wapi_load_config(ifname, confname, conf) NULL
Review comment:
```suggestion
# define wapi_load_config(ifname, confname, conf) NULL
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] anchao commented on a change in pull request
#98: netutils: add support to save wapi config to file system
Posted by GitBox <gi...@apache.org>.
anchao commented on a change in pull request #98: netutils: add support to save wapi config to file system
URL: https://github.com/apache/incubator-nuttx-apps/pull/98#discussion_r384271257
##########
File path: include/wireless/wapi.h
##########
@@ -95,6 +95,12 @@
# define SOCK_WAPI SOCK_STREAM
#endif
+#ifndef CONFIG_WIRELESS_WAPI_INITCONF
+#define wapi_load_config(ifname, confname, conf) NULL
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] anchao commented on a change in pull request
#98: netutils: add support to save wapi config to file system
Posted by GitBox <gi...@apache.org>.
anchao commented on a change in pull request #98: netutils: add support to save wapi config to file system
URL: https://github.com/apache/incubator-nuttx-apps/pull/98#discussion_r384271298
##########
File path: include/wireless/wapi.h
##########
@@ -95,6 +95,12 @@
# define SOCK_WAPI SOCK_STREAM
#endif
+#ifndef CONFIG_WIRELESS_WAPI_INITCONF
+#define wapi_load_config(ifname, confname, conf) NULL
+#define wapi_unload_config(load)
+#define wapi_save_config(ifname, confname, conf) 0
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] anchao commented on a change in pull request
#98: netutils: add support to save wapi config to file system
Posted by GitBox <gi...@apache.org>.
anchao commented on a change in pull request #98: netutils: add support to save wapi config to file system
URL: https://github.com/apache/incubator-nuttx-apps/pull/98#discussion_r384271277
##########
File path: include/wireless/wapi.h
##########
@@ -95,6 +95,12 @@
# define SOCK_WAPI SOCK_STREAM
#endif
+#ifndef CONFIG_WIRELESS_WAPI_INITCONF
+#define wapi_load_config(ifname, confname, conf) NULL
+#define wapi_unload_config(load)
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] Ouss4 commented on a change in pull request
#98: netutils: add support to save wapi config to file system
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #98: netutils: add support to save wapi config to file system
URL: https://github.com/apache/incubator-nuttx-apps/pull/98#discussion_r383844348
##########
File path: include/wireless/wapi.h
##########
@@ -95,6 +95,12 @@
# define SOCK_WAPI SOCK_STREAM
#endif
+#ifndef CONFIG_WIRELESS_WAPI_INITCONF
+#define wapi_load_config(ifname, confname, conf) NULL
+#define wapi_unload_config(load)
+#define wapi_save_config(ifname, confname, conf) 0
Review comment:
```suggestion
# define wapi_save_config(ifname, confname, conf) 0
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] Ouss4 commented on a change in pull request
#98: netutils: add support to save wapi config to file system
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #98: netutils: add support to save wapi config to file system
URL: https://github.com/apache/incubator-nuttx-apps/pull/98#discussion_r383844263
##########
File path: include/wireless/wapi.h
##########
@@ -95,6 +95,12 @@
# define SOCK_WAPI SOCK_STREAM
#endif
+#ifndef CONFIG_WIRELESS_WAPI_INITCONF
+#define wapi_load_config(ifname, confname, conf) NULL
+#define wapi_unload_config(load)
Review comment:
```suggestion
# define wapi_unload_config(load)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] Ouss4 merged pull request #98: netutils: add
support to save wapi config to file system
Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #98: netutils: add support to save wapi config to file system
URL: https://github.com/apache/incubator-nuttx-apps/pull/98
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services