You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "gaoyan1998 (via GitHub)" <gi...@apache.org> on 2024/05/06 03:12:30 UTC
[PR] Supports dinky tasks to accept Prepare Params passed within a task or from a previous task [dolphinscheduler]
gaoyan1998 opened a new pull request, #15947:
URL: https://github.com/apache/dolphinscheduler/pull/15947
## Purpose of the pull request
Supports dinky tasks to accept variables passed within a task or from a previous task
## Brief change log
## Verify this pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature]Supports dinky tasks to accept Prepare Params passed within a task or from a previous task [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15947:
URL: https://github.com/apache/dolphinscheduler/pull/15947#issuecomment-2136429664
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15947) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=15947&resolved=false&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=15947&resolutions=WONTFIX)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=15947&resolved=false&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15947&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15947&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15947)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature-16269][dinky-task]Supports dinky tasks to accept Prepare Params passed within a task or from a previous task [dolphinscheduler]
Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS merged PR #15947:
URL: https://github.com/apache/dolphinscheduler/pull/15947
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature]Supports dinky tasks to accept Prepare Params passed within a task or from a previous task [dolphinscheduler]
Posted by "gaoyan1998 (via GitHub)" <gi...@apache.org>.
gaoyan1998 commented on PR #15947:
URL: https://github.com/apache/dolphinscheduler/pull/15947#issuecomment-2101800756
> Please run `mvn spotless:apply` to format the code. @gaoyan1998
I have resolved it，please review it，thanks. @SbloodyS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature]Supports dinky tasks to accept Prepare Params passed within a task or from a previous task [dolphinscheduler]
Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS commented on PR #15947:
URL: https://github.com/apache/dolphinscheduler/pull/15947#issuecomment-2099570439
Please run `mvn spotless:apply` to format the code. @gaoyan1998
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature-16269][dinky-task]Supports dinky tasks to accept Prepare Params passed within a task or from a previous task [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15947:
URL: https://github.com/apache/dolphinscheduler/pull/15947#issuecomment-2207855218
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15947) **Quality Gate failed**
Failed conditions
 [45.8% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15947&metric=new_coverage&view=list) (required ≥ 60%)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15947)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature-16269][dinky-task]Supports dinky tasks to accept Prepare Params passed within a task or from a previous task [dolphinscheduler]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #15947:
URL: https://github.com/apache/dolphinscheduler/pull/15947#issuecomment-2207858407
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature]Supports dinky tasks to accept Prepare Params passed within a task or from a previous task [dolphinscheduler]
Posted by "gaoyan1998 (via GitHub)" <gi...@apache.org>.
gaoyan1998 commented on PR #15947:
URL: https://github.com/apache/dolphinscheduler/pull/15947#issuecomment-2107092893
@ruanwenjun Thanks for your suggestion, I have finished the revision
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature]Supports dinky tasks to accept Prepare Params passed within a task or from a previous task [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15947:
URL: https://github.com/apache/dolphinscheduler/pull/15947#issuecomment-2136430392
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15947) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=15947&resolved=false&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=15947&resolutions=WONTFIX)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=15947&resolved=false&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15947&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15947&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15947)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature-16269][dinky-task]Supports dinky tasks to accept Prepare Params passed within a task or from a previous task [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15947:
URL: https://github.com/apache/dolphinscheduler/pull/15947#issuecomment-2207772833
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15947) **Quality Gate failed**
Failed conditions
 [45.8% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15947&metric=new_coverage&view=list) (required ≥ 60%)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15947)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature]Supports dinky tasks to accept Prepare Params passed within a task or from a previous task [dolphinscheduler]
Posted by "gaoyan1998 (via GitHub)" <gi...@apache.org>.
gaoyan1998 commented on PR #15947:
URL: https://github.com/apache/dolphinscheduler/pull/15947#issuecomment-2132519797
hi @ruanwenjun PTAL ,please approval workflows
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature]Supports dinky tasks to accept Prepare Params passed within a task or from a previous task [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15947:
URL: https://github.com/apache/dolphinscheduler/pull/15947#issuecomment-2102361680
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15947) **Quality Gate failed**
Failed conditions
 [36.4% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15947&metric=new_coverage&view=list) (required ≥ 60%)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15947)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature]Supports dinky tasks to accept Prepare Params passed within a task or from a previous task [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15947:
URL: https://github.com/apache/dolphinscheduler/pull/15947#issuecomment-2101976477
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15947) **Quality Gate failed**
Failed conditions
 [B Maintainability Rating on New Code](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15947) (required ≥ A)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15947)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature]Supports dinky tasks to accept Prepare Params passed within a task or from a previous task [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15947:
URL: https://github.com/apache/dolphinscheduler/pull/15947#issuecomment-2101977583
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15947) **Quality Gate failed**
Failed conditions
 [B Maintainability Rating on New Code](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15947) (required ≥ A)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15947)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature-16269][dinky-task]Supports dinky tasks to accept Prepare Params passed within a task or from a previous task [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15947:
URL: https://github.com/apache/dolphinscheduler/pull/15947#issuecomment-2207772640
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15947) **Quality Gate failed**
Failed conditions
 [45.8% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15947&metric=new_coverage&view=list) (required ≥ 60%)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15947)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature]Supports dinky tasks to accept Prepare Params passed within a task or from a previous task [dolphinscheduler]
Posted by "gaoyan1998 (via GitHub)" <gi...@apache.org>.
gaoyan1998 commented on PR #15947:
URL: https://github.com/apache/dolphinscheduler/pull/15947#issuecomment-2097702902
> Please supplement the document. @gaoyan1998
@SbloodyS PTAL, Supplement the documentation done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature]Supports dinky tasks to accept Prepare Params passed within a task or from a previous task [dolphinscheduler]
Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun commented on code in PR #15947:
URL: https://github.com/apache/dolphinscheduler/pull/15947#discussion_r1594970882
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-dinky/src/main/java/org/apache/dolphinscheduler/plugin/task/dinky/DinkyTask.java:
##########
@@ -343,15 +344,30 @@ private Map<String, String> generateVariables() {
}
}
List<Property> localParams = this.dinkyParameters.getLocalParams();
+ Map<String, Property> prepareParamsMap = taskExecutionContext.getPrepareParamsMap();
if (localParams == null || localParams.isEmpty()) {
return variables;
}
+ Map<String, String> convertMap = convert(prepareParamsMap);
for (Property property : localParams) {
- variables.put(property.getProp(), property.getValue());
+ String propertyValue = property.getValue();
+ String value = PlaceholderUtils.replacePlaceholders(propertyValue, convertMap, true);
+ variables.put(property.getProp(), value);
}
return variables;
}
+ public static Map<String, String> convert(Map<String, Property> paramsMap) {
+ if (paramsMap == null) {
+ return null;
+ }
+ Map<String, String> map = new HashMap<>();
+ for (Map.Entry<String, Property> en : paramsMap.entrySet()) {
+ map.put(en.getKey(), en.getValue().getValue());
+ }
+ return map;
+ }
+
Review Comment:
```suggestion
```
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-dinky/src/main/java/org/apache/dolphinscheduler/plugin/task/dinky/DinkyTask.java:
##########
@@ -343,15 +344,30 @@ private Map<String, String> generateVariables() {
}
}
List<Property> localParams = this.dinkyParameters.getLocalParams();
+ Map<String, Property> prepareParamsMap = taskExecutionContext.getPrepareParamsMap();
if (localParams == null || localParams.isEmpty()) {
return variables;
}
+ Map<String, String> convertMap = convert(prepareParamsMap);
Review Comment:
```suggestion
Map<String, String> convertMap = ParameterUtils.convert(prepareParamsMap);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature]Supports dinky tasks to accept Prepare Params passed within a task or from a previous task [dolphinscheduler]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #15947:
URL: https://github.com/apache/dolphinscheduler/pull/15947#issuecomment-2095418739
## [Codecov](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15947?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 39.81%. Comparing base [(`d218b02`)](https://app.codecov.io/gh/apache/dolphinscheduler/commit/d218b021e7e045e7982a3c91ea7b1b1491d21d38?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`35e959e`)](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15947?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> :exclamation: Current head 35e959e differs from pull request most recent head 81bfba1. Consider uploading reports for the commit 81bfba1 to get more accurate results
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## dev #15947 +/- ##
============================================
- Coverage 39.88% 39.81% -0.07%
+ Complexity 5059 5038 -21
============================================
Files 1354 1354
Lines 45659 45621 -38
Branches 4894 4869 -25
============================================
- Hits 18212 18166 -46
- Misses 25541 25550 +9
+ Partials 1906 1905 -1
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15947?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature-16269][dinky-task]Supports dinky tasks to accept Prepare Params passed within a task or from a previous task [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15947:
URL: https://github.com/apache/dolphinscheduler/pull/15947#issuecomment-2207855631
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15947) **Quality Gate failed**
Failed conditions
 [45.8% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15947&metric=new_coverage&view=list) (required ≥ 60%)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15947)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature]Supports dinky tasks to accept Prepare Params passed within a task or from a previous task [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15947:
URL: https://github.com/apache/dolphinscheduler/pull/15947#issuecomment-2095430470
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15947) **Quality Gate failed**
Failed conditions
 [B Maintainability Rating on New Code](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15947) (required ≥ A)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15947)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature]Supports dinky tasks to accept Prepare Params passed within a task or from a previous task [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15947:
URL: https://github.com/apache/dolphinscheduler/pull/15947#issuecomment-2095428981
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15947) **Quality Gate failed**
Failed conditions
 [B Maintainability Rating on New Code](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15947) (required ≥ A)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15947)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature]Supports dinky tasks to accept Prepare Params passed within a task or from a previous task [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15947:
URL: https://github.com/apache/dolphinscheduler/pull/15947#issuecomment-2102363005
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15947) **Quality Gate failed**
Failed conditions
 [36.4% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15947&metric=new_coverage&view=list) (required ≥ 60%)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15947)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org