You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by cpoerschke <gi...@git.apache.org> on 2014/11/11 18:04:24 UTC
[GitHub] lucene-solr pull request: select?replicaAffinity=(node|host) and r...
GitHub user cpoerschke opened a pull request:
https://github.com/apache/lucene-solr/pull/104
select?replicaAffinity=(node|host) and replicaAffinity.hostPriorities support
https://issues.apache.org/jira/i#browse/SOLR-6730
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bloomberg/lucene-solr trunk-replica-affinity-feature
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/104.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #104
----
commit 66b56265bdefec7eb814bfb533c0ff19bb1dcdff
Author: Christine Poerschke <cp...@bloomberg.net>
Date: 2014-08-12T10:32:57Z
solr: select?replicaAffinity=(node|host) and replicaAffinity.hostPriorities support
This commit also includes changes to reduce SearchHandler's overall use of ShardHandler objects.
---------
solr: select?replicaAffinity=(node|host) support, select?replicaAffinity=host&replicaAffinity.hostPriorities=hostA,hostB=1,hostC=2,hostD=2,hostE=3 prioritisation support
illustration: `4-hosts-x-2-ports=8-instances 8-shards 2-replica system`
http://host1:port1/solr/collection1_shard1_replicaA/
http://host1:port1/solr/collection1_shard3_replicaA/
http://host1:port2/solr/collection1_shard5_replicaA/
http://host1:port2/solr/collection1_shard7_replicaA/
http://host2:port1/solr/collection1_shard2_replicaA/
http://host2:port1/solr/collection1_shard4_replicaA/
http://host2:port2/solr/collection1_shard6_replicaA/
http://host2:port2/solr/collection1_shard8_replicaA/
http://host3:port1/solr/collection1_shard1_replicaB/
http://host3:port1/solr/collection1_shard3_replicaB/
http://host3:port2/solr/collection1_shard5_replicaB/
http://host3:port2/solr/collection1_shard7_replicaB/
http://host4:port1/solr/collection1_shard2_replicaB/
http://host4:port1/solr/collection1_shard4_replicaB/
http://host4:port2/solr/collection1_shard6_replicaB/
http://host4:port2/solr/collection1_shard8_replicaB/
`.../select` plain will route sub-requests to a random selection of solr cores and so could potentially use all 8 JVM instances
http://host1:port1/solr/collection1_shard1_replicaA/
http://host4:port1/solr/collection1_shard2_replicaB/
http://host3:port1/solr/collection1_shard3_replicaB/
http://host2:port1/solr/collection1_shard4_replicaA/
http://host1:port2/solr/collection1_shard5_replicaA/
http://host4:port2/solr/collection1_shard6_replicaB/
http://host3:port2/solr/collection1_shard7_replicaB/
http://host2:port2/solr/collection1_shard8_replicaA/
`.../select?replicaAffinity=node` will route sub-requests to a random selection of solr cores whilst maintaining node affinity i.e. sub-requests that can go to the same solr instance will go to the same solr instance e.g.
http://host1:port1/solr/collection1_shard1_replicaA/
http://host4:port1/solr/collection1_shard2_replicaB/
http://host1:port1/solr/collection1_shard3_replicaA/
http://host4:port1/solr/collection1_shard4_replicaB/
http://host3:port2/solr/collection1_shard5_replicaB/
http://host2:port2/solr/collection1_shard6_replicaA/
http://host3:port2/solr/collection1_shard7_replicaB/
http://host2:port2/solr/collection1_shard8_replicaA/
`.../select?replicaAffinity=host` will route sub-requests to a random selection of solr cores whilst maintaining host affinity i.e. sub-requests that can go to the same host machine will go to the same host machine e.g.
http://host1:port1/solr/collection1_shard1_replicaA/
http://host2:port1/solr/collection1_shard2_replicaA/
http://host1:port1/solr/collection1_shard3_replicaA/
http://host2:port1/solr/collection1_shard4_replicaA/
http://host1:port2/solr/collection1_shard5_replicaA/
http://host2:port2/solr/collection1_shard6_replicaA/
http://host1:port2/solr/collection1_shard7_replicaA/
http://host2:port2/solr/collection1_shard8_replicaA/
`.../select?replicaAffinity=host&replicaAffinity=node` will route sub-requests to a random selection of solr cores whilst maintaining first host affinity and secondly node affinity (the latter clearly only applies if multiple JVMs on a given machine contain the same shard).
If `replicaAffinity=host` is requested then optional `replicaAffinity.hostPriorities` are supported:
`.../select?replicaAffinity=host&replicaAffinity.hostPriorities=hostX=2,hostY=2,hostZ=1` will route sub-requests to hostZ (priority 1) for shards that are available on that host, to randomly either hostX or hostY (both priority 2) for shards available on those two hosts but not available on a priority 1 host.
`replicaAffinity.hostPriorities=hostZ` and `replicaAffinity.hostPriorities=hostZ=1` are equivalent.
If host priorities are supplied they can be just a subset of all hosts, preference will be given to live nodes on the prioritised hosts and random selections will be made for the remaining sub-requests.
---------
solr: reduce SearchHandler's overall use of ShardHandler objects (from N+1+x to just 1)
before:
* A search request to an N-shard system constructs N+1+x ShardHandler objects in total:
* 1 object in the receiving solr instance
* 1 object in each of the N shards that receive an initial sub-request (for top ids or top group ids)
* 1 object in each of x shards that receive a subsequent sub-request (for top ids within group or to get fields)
after:
* A search request to an N-shard systems constructs 1 ShardHandler object in the receiving solr instance only.
summary of change:
* move non-distrib related code fragments from HttpShardHandler.checkDistrib to SearchHandler
* rename ShardHandler.checkDistrib to ShardHandler.prepDistrib (to be called for distributed requests only)
* SearchHandler constructs ShardHandler object only for distributed requests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #104: SOLR-8593 - WIP
Posted by joel-bernstein <gi...@git.apache.org>.
Github user joel-bernstein commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r92718063
--- Diff: solr/solrj/src/java/org/apache/solr/client/solrj/io/ops/GreaterThanOperation.java ---
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.solr.client.solrj.io.ops;
+
+import java.io.IOException;
+import java.util.UUID;
+
+import org.apache.solr.client.solrj.io.Tuple;
+import org.apache.solr.client.solrj.io.stream.expr.Explanation;
+import org.apache.solr.client.solrj.io.stream.expr.Explanation.ExpressionType;
+import org.apache.solr.client.solrj.io.stream.expr.StreamExpression;
+import org.apache.solr.client.solrj.io.stream.expr.StreamFactory;
+
+public class GreaterThanOperation extends LeafOperation {
+
+ private static final long serialVersionUID = 1;
+ private UUID operationNodeId = UUID.randomUUID();
+
+ public void operate(Tuple tuple) {
+ this.tuple = tuple;
+ }
+
+ public GreaterThanOperation(String field, double val) {
--- End diff --
This is the implementation Tuple.getDouble():
public Double getDouble(Object key) {
Object o = this.fields.get(key);
if(o == null) {
return null;
}
if(o instanceof Double) {
return (Double)o;
} else {
//Attempt to parse the double
return Double.parseDouble(o.toString());
}
}
So, any number will be translated to a double for comparison. We can implement a String comparison in a different operation I think.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #104: Jira/solr 8593
Posted by risdenk <gi...@git.apache.org>.
Github user risdenk commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r85477051
--- Diff: solr/core/src/java/org/apache/solr/handler/sql/LimitStream.java ---
@@ -0,0 +1,89 @@
+/*
--- End diff --
Not sure this class is even necessary...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #104: Jira/solr 8593
Posted by risdenk <gi...@git.apache.org>.
Github user risdenk commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r85477095
--- Diff: solr/core/src/java/org/apache/solr/handler/SQLHandler.java ---
@@ -126,30 +101,46 @@ public void handleRequestBody(SolrQueryRequest req, SolrQueryResponse rsp) throw
throw new Exception("stmt parameter cannot be null");
}
- context.setSolrClientCache(StreamHandler.clientCache);
+ String url = "jdbc:calcitesolr:";
+
+ Properties properties = new Properties();
+ // Add all query parameters
+ Iterator<String> parameterNamesIterator = params.getParameterNamesIterator();
+ while(parameterNamesIterator.hasNext()) {
+ String param = parameterNamesIterator.next();
+ properties.setProperty(param, params.get(param));
+ }
+
+ // Set these last to ensure that they are set properly
+ properties.setProperty("lex", Lex.MYSQL.toString());
+ properties.setProperty("zk", defaultZkhost);
+
+ String driverClass = CalciteSolrDriver.class.getCanonicalName();
+
+ // JDBC driver requires metadata from the SQLHandler. Default to false since this adds a new Metadata stream.
+ if(params.getBool("includeMetadata", false)) {
+ /*
+ * Would be great to replace this with the JDBCStream. Can't do that currently since need to have metadata
+ * added to the stream for the JDBC driver. This could be fixed by using the Calcite Avatica server and client.
+ */
+ tupleStream = new SqlHandlerStream(url, sql, properties, driverClass);
--- End diff --
Would be awesome to use JDBCStream in SqlHandlerStream...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #104: SOLR-8593 - WIP
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/lucene-solr/pull/104
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #104: Jira/solr 8593
Posted by risdenk <gi...@git.apache.org>.
Github user risdenk commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r85476907
--- Diff: solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/JDBCStream.java ---
@@ -223,7 +223,7 @@ public void open() throws IOException {
for(int columnIdx = 0; columnIdx < metadata.getColumnCount(); ++columnIdx){
final int columnNumber = columnIdx + 1; // cause it starts at 1
- final String columnName = metadata.getColumnName(columnNumber);
+ final String columnName = metadata.getColumnLabel(columnNumber);
--- End diff --
This makes sure to use the `AS` value instead of just the original column name.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #104: Jira/solr 8593
Posted by risdenk <gi...@git.apache.org>.
Github user risdenk commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r85476713
--- Diff: lucene/ivy-versions.properties ---
@@ -99,6 +98,13 @@ io.netty.netty-all.version = 4.0.36.Final
/org.apache.ant/ant = 1.8.2
/org.apache.avro/avro = 1.7.5
+
+org.apache.calcite.version = 1.10.0
--- End diff --
Need 1.11
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #104: Jira/solr 8593
Posted by risdenk <gi...@git.apache.org>.
Github user risdenk commented on the issue:
https://github.com/apache/lucene-solr/pull/104
Filter is needed for the Lucene query parsing piece. The rules aren't completely correct. Some issues with `is not` and others that need to add some tests for. It does compile though and able to do things like `select * ...`. I'm thinking back out a few of the rules to make this simpler then incrementally add from there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #104: Jira/solr 8593
Posted by risdenk <gi...@git.apache.org>.
Github user risdenk commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r85476724
--- Diff: lucene/ivy-versions.properties ---
@@ -99,6 +98,13 @@ io.netty.netty-all.version = 4.0.36.Final
/org.apache.ant/ant = 1.8.2
/org.apache.avro/avro = 1.7.5
+
+org.apache.calcite.version = 1.10.0
+org.apache.calcite.avatica.version = 1.9.0-SNAPSHOT
--- End diff --
Need 1.9.0 final
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #104: Jira/solr 8593
Posted by risdenk <gi...@git.apache.org>.
Github user risdenk commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r85476827
--- Diff: solr/solrj/src/test/org/apache/solr/client/solrj/io/stream/JDBCStreamTest.java ---
@@ -354,8 +354,8 @@ public void testJDBCSolrInnerJoinExpressionWithProperties() throws Exception{
+ " rating_f as rating"
+ " ),"
+ " select("
- + " jdbc(connection=\"jdbc:hsqldb:mem:.\", sql=\"select PEOPLE.ID as PERSONID, PEOPLE.NAME, COUNTRIES.COUNTRY_NAME from PEOPLE inner join COUNTRIES on PEOPLE.COUNTRY_CODE = COUNTRIES.CODE order by PEOPLE.ID\", sort=\"ID asc\", get_column_name=true),"
- + " ID as personId,"
+ + " jdbc(connection=\"jdbc:hsqldb:mem:.\", sql=\"select PEOPLE.ID as PERSONID, PEOPLE.NAME, COUNTRIES.COUNTRY_NAME from PEOPLE inner join COUNTRIES on PEOPLE.COUNTRY_CODE = COUNTRIES.CODE order by PEOPLE.ID\", sort=\"PERSONID asc\", get_column_name=true),"
--- End diff --
Need to fix comment a few lines up from here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #104: SOLR-8593 - WIP
Posted by risdenk <gi...@git.apache.org>.
Github user risdenk commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r97372920
--- Diff: lucene/ivy-versions.properties ---
@@ -36,7 +34,7 @@ com.google.inject.guice.version = 3.0
/com.google.inject.extensions/guice-servlet = ${com.google.inject.guice.version}
/com.google.inject/guice = ${com.google.inject.guice.version}
-/com.google.protobuf/protobuf-java = 2.5.0
+/com.google.protobuf/protobuf-java = 3.1.0
--- End diff --
@markrmiller Can this be updated with the Hadoop support? Tests seem to pass but not sure if this affects protobuf compatibility with a running cluster.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #104: Jira/solr 8593
Posted by risdenk <gi...@git.apache.org>.
Github user risdenk commented on the issue:
https://github.com/apache/lucene-solr/pull/104
https://github.com/apache/lucene-solr/tree/jira/solr-8593
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #104: Jira/solr 8593
Posted by joel-bernstein <gi...@git.apache.org>.
Github user joel-bernstein commented on the issue:
https://github.com/apache/lucene-solr/pull/104
Hi Kevin,
Shall we push a branch out to apache/lucene-solr for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #104: SOLR-8593 - WIP
Posted by risdenk <gi...@git.apache.org>.
Github user risdenk commented on the issue:
https://github.com/apache/lucene-solr/pull/104
@joel-bernstein if you push to the `jira/solr-8593` branch it should update this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #104: Jira/solr 8593
Posted by risdenk <gi...@git.apache.org>.
Github user risdenk commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r85476962
--- Diff: solr/core/src/test/org/apache/solr/handler/TestSQLHandler.java ---
@@ -80,228 +70,24 @@ private void delete() throws Exception {
@Test
public void doTest() throws Exception {
waitForRecoveriesToFinish(false);
- testPredicate();
testBasicSelect();
--- End diff --
Need to enable all the tests again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #104: Jira/solr 8593
Posted by risdenk <gi...@git.apache.org>.
Github user risdenk commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r85476784
--- Diff: solr/core/src/java/org/apache/solr/handler/SQLHandler.java ---
@@ -126,30 +101,46 @@ public void handleRequestBody(SolrQueryRequest req, SolrQueryResponse rsp) throw
throw new Exception("stmt parameter cannot be null");
}
- context.setSolrClientCache(StreamHandler.clientCache);
+ String url = "jdbc:calcitesolr:";
--- End diff --
Need to use constant in driver.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #104: Jira/solr 8593
Posted by risdenk <gi...@git.apache.org>.
Github user risdenk commented on the issue:
https://github.com/apache/lucene-solr/pull/104
This is on `apache/lucene-solr` already. It is branch `jira/solr-8593`. I opened the PR just so I could comment on some of the files.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #104: SOLR-8593 - WIP
Posted by joel-bernstein <gi...@git.apache.org>.
Github user joel-bernstein commented on the issue:
https://github.com/apache/lucene-solr/pull/104
Ok, got it. I'll pull the branch and start working with it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #104: Jira/solr 8593
Posted by risdenk <gi...@git.apache.org>.
Github user risdenk commented on the issue:
https://github.com/apache/lucene-solr/pull/104
@joel-bernstein FYI
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #104: Jira/solr 8593
Posted by risdenk <gi...@git.apache.org>.
Github user risdenk commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r85476668
--- Diff: lucene/default-nested-ivy-settings.xml ---
@@ -50,6 +51,7 @@
<resolver ref="local"/>
<!-- <resolver ref="local-maven-2" /> -->
<resolver ref="main"/>
+ <resolver ref="apache-snapshot" />
--- End diff --
Need to remove
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #104: Jira/solr 8593
Posted by risdenk <gi...@git.apache.org>.
Github user risdenk commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r85476761
--- Diff: solr/core/src/java/org/apache/calcite/config/CalciteConnectionProperty.java ---
@@ -0,0 +1,182 @@
+/*
--- End diff --
This whole files needs to be removed when Calcite upgrades to Avatica 1.9 and releases 1.11 most likely
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #104: Jira/solr 8593
Posted by risdenk <gi...@git.apache.org>.
Github user risdenk commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r85476652
--- Diff: lucene/default-nested-ivy-settings.xml ---
@@ -32,6 +32,7 @@
<caches lockStrategy="${ivy.lock-strategy}" resolutionCacheDir="${ivy.resolution-cache.dir}" />
<resolvers>
+ <ibiblio name="apache-snapshot" root="https://repository.apache.org/content/repositories/snapshots" m2compatible="true" />
--- End diff --
Need to remove when Avatica 1.9 and Calcite 1.11 is released
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #104: SOLR-8593 - WIP
Posted by risdenk <gi...@git.apache.org>.
Github user risdenk commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r85965892
--- Diff: lucene/default-nested-ivy-settings.xml ---
@@ -32,6 +32,7 @@
<caches lockStrategy="${ivy.lock-strategy}" resolutionCacheDir="${ivy.resolution-cache.dir}" />
<resolvers>
+ <ibiblio name="apache-snapshot" root="https://repository.apache.org/content/repositories/snapshots" m2compatible="true" />
--- End diff --
Avatica 1.9 released and PR updated. Waiting on Calcite 1.11.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #104: SOLR-8593 - WIP
Posted by risdenk <gi...@git.apache.org>.
Github user risdenk commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r92703928
--- Diff: solr/solrj/src/java/org/apache/solr/client/solrj/io/ops/GreaterThanOperation.java ---
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.solr.client.solrj.io.ops;
+
+import java.io.IOException;
+import java.util.UUID;
+
+import org.apache.solr.client.solrj.io.Tuple;
+import org.apache.solr.client.solrj.io.stream.expr.Explanation;
+import org.apache.solr.client.solrj.io.stream.expr.Explanation.ExpressionType;
+import org.apache.solr.client.solrj.io.stream.expr.StreamExpression;
+import org.apache.solr.client.solrj.io.stream.expr.StreamFactory;
+
+public class GreaterThanOperation extends LeafOperation {
+
+ private static final long serialVersionUID = 1;
+ private UUID operationNodeId = UUID.randomUUID();
+
+ public void operate(Tuple tuple) {
+ this.tuple = tuple;
+ }
+
+ public GreaterThanOperation(String field, double val) {
--- End diff --
@joel-bernstein - Does this mean that string/int/long comparisons won't work? I noticed that this assumes the fields are doubles.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #104: Jira/solr 8593
Posted by risdenk <gi...@git.apache.org>.
Github user risdenk commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/104#discussion_r85476697
--- Diff: lucene/ivy-versions.properties ---
@@ -36,7 +34,7 @@ com.google.inject.guice.version = 3.0
/com.google.inject.extensions/guice-servlet = ${com.google.inject.guice.version}
/com.google.inject/guice = ${com.google.inject.guice.version}
-/com.google.protobuf/protobuf-java = 2.5.0
+/com.google.protobuf/protobuf-java = 3.1.0
--- End diff --
Can this be updated? Needed for Calcite/Avatica.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org