[jira] [Commented] (ORC-256) Add unmasked ranges option for redact mask

["Owen O'Malley (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ORC-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251980#comment-16251980 ] 

Owen O'Malley commented on ORC-256:
-----------------------------------

Ok, this is getting close. However, the numerics are more painful that I expected. Sorry about that!

A couple of suggestions:
* We'd do better with an explicit Range class that held the start/end and make an ArrayList of those. It would be much faster to iterate over. There isn't any need for a synchronized container class in this context.
* You have some spurious whitespace changes at line 271 & 291.
* It probably is easier to reason about the numerics if we:
  * Use the original code if there is no unmasking.
  * Convert the original value to a string, use maskString, and then convert it back.  

> Add unmasked ranges option for redact mask
> ------------------------------------------
>
>                 Key: ORC-256
>                 URL: https://issues.apache.org/jira/browse/ORC-256
>             Project: ORC
>          Issue Type: Sub-task
>            Reporter: Owen O'Malley
>            Assignee: Sandeep More
>
> It would be good to extend the Redact DataMask so that you could leave certain ranges of strings unmasked.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)