You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "William Henry (JIRA)" <qp...@incubator.apache.org> on 2008/08/01 23:01:32 UTC
[jira] Created: (QPID-1214) Requirement to be able to purge the top
item or top n items from a queue.
Requirement to be able to purge the top item or top n items from a queue.
--------------------------------------------------------------------------
Key: QPID-1214
URL: https://issues.apache.org/jira/browse/QPID-1214
Project: Qpid
Issue Type: New Feature
Components: C++ Broker, Python Test Suite
Reporter: William Henry
This was originally the requirement to unblock a queue. However after first implemented it seemed better to modify purge, which purges all, to purge just the top message or the top n messages.
I want to at a test so that this gets tested on make check. (Currently there is not a check for the purge at all).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (QPID-1214) Requirement to be able to purge the
top item or top n items from a queue.
Posted by "Ted Ross (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Ross reassigned QPID-1214:
------------------------------
Assignee: Ted Ross
> Requirement to be able to purge the top item or top n items from a queue.
> --------------------------------------------------------------------------
>
> Key: QPID-1214
> URL: https://issues.apache.org/jira/browse/QPID-1214
> Project: Qpid
> Issue Type: New Feature
> Components: C++ Broker, Python Test Suite
> Reporter: William Henry
> Assignee: Ted Ross
> Attachments: purgenfeature.diff
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> This was originally the requirement to unblock a queue. However after first implemented it seemed better to modify purge, which purges all, to purge just the top message or the top n messages.
> I want to at a test so that this gets tested on make check. (Currently there is not a check for the purge at all).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (QPID-1214) Requirement to be able to purge the top
item or top n items from a queue.
Posted by "William Henry (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
William Henry updated QPID-1214:
--------------------------------
Attachment: (was: purgefeature.diff)
> Requirement to be able to purge the top item or top n items from a queue.
> --------------------------------------------------------------------------
>
> Key: QPID-1214
> URL: https://issues.apache.org/jira/browse/QPID-1214
> Project: Qpid
> Issue Type: New Feature
> Components: C++ Broker, Python Test Suite
> Reporter: William Henry
> Assignee: Ted Ross
> Attachments: purgefeature.diff
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> This was originally the requirement to unblock a queue. However after first implemented it seemed better to modify purge, which purges all, to purge just the top message or the top n messages.
> I want to at a test so that this gets tested on make check. (Currently there is not a check for the purge at all).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (QPID-1214) Requirement to be able to purge the top
item or top n items from a queue.
Posted by "William Henry (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
William Henry updated QPID-1214:
--------------------------------
Attachment: purgefeature.diff
This is the patch for purge all/top/n
> Requirement to be able to purge the top item or top n items from a queue.
> --------------------------------------------------------------------------
>
> Key: QPID-1214
> URL: https://issues.apache.org/jira/browse/QPID-1214
> Project: Qpid
> Issue Type: New Feature
> Components: C++ Broker, Python Test Suite
> Reporter: William Henry
> Assignee: Ted Ross
> Attachments: purgefeature.diff
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> This was originally the requirement to unblock a queue. However after first implemented it seemed better to modify purge, which purges all, to purge just the top message or the top n messages.
> I want to at a test so that this gets tested on make check. (Currently there is not a check for the purge at all).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (QPID-1214) Requirement to be able to purge the top
item or top n items from a queue.
Posted by "William Henry (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
William Henry updated QPID-1214:
--------------------------------
Attachment: purgefeature.diff
The earlier upload had a bug and some commented out code that I fixed and removed respectively.
> Requirement to be able to purge the top item or top n items from a queue.
> --------------------------------------------------------------------------
>
> Key: QPID-1214
> URL: https://issues.apache.org/jira/browse/QPID-1214
> Project: Qpid
> Issue Type: New Feature
> Components: C++ Broker, Python Test Suite
> Reporter: William Henry
> Assignee: Ted Ross
> Attachments: purgefeature.diff, purgenfeature.diff
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> This was originally the requirement to unblock a queue. However after first implemented it seemed better to modify purge, which purges all, to purge just the top message or the top n messages.
> I want to at a test so that this gets tested on make check. (Currently there is not a check for the purge at all).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (QPID-1214) Requirement to be able to purge the top
item or top n items from a queue.
Posted by "William Henry (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
William Henry updated QPID-1214:
--------------------------------
Attachment: (was: purgenfeature.diff)
> Requirement to be able to purge the top item or top n items from a queue.
> --------------------------------------------------------------------------
>
> Key: QPID-1214
> URL: https://issues.apache.org/jira/browse/QPID-1214
> Project: Qpid
> Issue Type: New Feature
> Components: C++ Broker, Python Test Suite
> Reporter: William Henry
> Assignee: Ted Ross
> Attachments: purgefeature.diff
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> This was originally the requirement to unblock a queue. However after first implemented it seemed better to modify purge, which purges all, to purge just the top message or the top n messages.
> I want to at a test so that this gets tested on make check. (Currently there is not a check for the purge at all).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (QPID-1214) Requirement to be able to purge the top
item or top n items from a queue.
Posted by "William Henry (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
William Henry updated QPID-1214:
--------------------------------
Attachment: (was: purgefeature.diff)
> Requirement to be able to purge the top item or top n items from a queue.
> --------------------------------------------------------------------------
>
> Key: QPID-1214
> URL: https://issues.apache.org/jira/browse/QPID-1214
> Project: Qpid
> Issue Type: New Feature
> Components: C++ Broker, Python Test Suite
> Reporter: William Henry
> Assignee: Ted Ross
> Attachments: purgenfeature.diff
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> This was originally the requirement to unblock a queue. However after first implemented it seemed better to modify purge, which purges all, to purge just the top message or the top n messages.
> I want to at a test so that this gets tested on make check. (Currently there is not a check for the purge at all).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (QPID-1214) Requirement to be able to purge the top
item or top n items from a queue.
Posted by "William Henry (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
William Henry updated QPID-1214:
--------------------------------
Attachment: purgefeature.diff
I left in some commented out code. I removed it here.
> Requirement to be able to purge the top item or top n items from a queue.
> --------------------------------------------------------------------------
>
> Key: QPID-1214
> URL: https://issues.apache.org/jira/browse/QPID-1214
> Project: Qpid
> Issue Type: New Feature
> Components: C++ Broker, Python Test Suite
> Reporter: William Henry
> Assignee: Ted Ross
> Attachments: purgefeature.diff, purgenfeature.diff
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> This was originally the requirement to unblock a queue. However after first implemented it seemed better to modify purge, which purges all, to purge just the top message or the top n messages.
> I want to at a test so that this gets tested on make check. (Currently there is not a check for the purge at all).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (QPID-1214) Requirement to be able to purge the
top item or top n items from a queue.
Posted by "Ted Ross (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Ross resolved QPID-1214.
----------------------------
Resolution: Fixed
Fix Version/s: M3
> Requirement to be able to purge the top item or top n items from a queue.
> --------------------------------------------------------------------------
>
> Key: QPID-1214
> URL: https://issues.apache.org/jira/browse/QPID-1214
> Project: Qpid
> Issue Type: New Feature
> Components: C++ Broker, Python Test Suite
> Reporter: William Henry
> Assignee: Ted Ross
> Fix For: M3
>
> Attachments: purgefeature.diff
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> This was originally the requirement to unblock a queue. However after first implemented it seemed better to modify purge, which purges all, to purge just the top message or the top n messages.
> I want to at a test so that this gets tested on make check. (Currently there is not a check for the purge at all).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (QPID-1214) Requirement to be able to purge the top
item or top n items from a queue.
Posted by "William Henry (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
William Henry updated QPID-1214:
--------------------------------
Attachment: purgenfeature.diff
This is just the diff file.
> Requirement to be able to purge the top item or top n items from a queue.
> --------------------------------------------------------------------------
>
> Key: QPID-1214
> URL: https://issues.apache.org/jira/browse/QPID-1214
> Project: Qpid
> Issue Type: New Feature
> Components: C++ Broker, Python Test Suite
> Reporter: William Henry
> Attachments: purgenfeature.diff
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> This was originally the requirement to unblock a queue. However after first implemented it seemed better to modify purge, which purges all, to purge just the top message or the top n messages.
> I want to at a test so that this gets tested on make check. (Currently there is not a check for the purge at all).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (QPID-1214) Requirement to be able to purge the
top item or top n items from a queue.
Posted by "Ted Ross (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12619654#action_12619654 ]
Ted Ross commented on QPID-1214:
--------------------------------
William,
This patch looks pretty good. I have a couple of minor, and mostly cosmetic, comments I'll make for one last go around.
1) The Qpid C++ coding convention calls for 4-space indentation with no tab characters. Please don't submit patches that introduce tab characters. (I concede that the one file: SessionAdapter.cpp was filled with tabs before you got to it).
2) I recommend using a default value for the argument on Queue::purge (in Queue.h) such that calls to Queue::purge() remove all messages from the queue. This ensures that the meaning of the method is unchanged for existing users and no changes to SessionAdapter are needed.
3) The "if" clause in the following code fragment (Queue::purge) doesn't do anything and should be removed:
+ unsigned long purge_count = 0;
+ if (purge_request)
+ {
+ purge_count = purge_request;
+ }
4) In the same routine, there is mixed use of "uint32_t" and "unsigned long". I suggest using uint32_t in all cases. Also (again, pre-existing), the return value is uint32_t, but the count that is returned is an int.
5) In the schema, the method argument is called "request". This is pretty nondescript. Can we call it "count" (or something similar) and provide a desc="" text to describe its use?
-Ted
> Requirement to be able to purge the top item or top n items from a queue.
> --------------------------------------------------------------------------
>
> Key: QPID-1214
> URL: https://issues.apache.org/jira/browse/QPID-1214
> Project: Qpid
> Issue Type: New Feature
> Components: C++ Broker, Python Test Suite
> Reporter: William Henry
> Assignee: Ted Ross
> Attachments: purgefeature.diff
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> This was originally the requirement to unblock a queue. However after first implemented it seemed better to modify purge, which purges all, to purge just the top message or the top n messages.
> I want to at a test so that this gets tested on make check. (Currently there is not a check for the purge at all).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (QPID-1214) Requirement to be able to purge the top
item or top n items from a queue.
Posted by "William Henry (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
William Henry updated QPID-1214:
--------------------------------
Attachment: (was: purgefeature.diff)
> Requirement to be able to purge the top item or top n items from a queue.
> --------------------------------------------------------------------------
>
> Key: QPID-1214
> URL: https://issues.apache.org/jira/browse/QPID-1214
> Project: Qpid
> Issue Type: New Feature
> Components: C++ Broker, Python Test Suite
> Reporter: William Henry
> Assignee: Ted Ross
> Attachments: purgefeature.diff
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> This was originally the requirement to unblock a queue. However after first implemented it seemed better to modify purge, which purges all, to purge just the top message or the top n messages.
> I want to at a test so that this gets tested on make check. (Currently there is not a check for the purge at all).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (QPID-1214) Requirement to be able to purge the top
item or top n items from a queue.
Posted by "William Henry (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
William Henry updated QPID-1214:
--------------------------------
Attachment: purgefeature.diff
Latest patch with the fixes that tross recommended.
> Requirement to be able to purge the top item or top n items from a queue.
> --------------------------------------------------------------------------
>
> Key: QPID-1214
> URL: https://issues.apache.org/jira/browse/QPID-1214
> Project: Qpid
> Issue Type: New Feature
> Components: C++ Broker, Python Test Suite
> Reporter: William Henry
> Assignee: Ted Ross
> Attachments: purgefeature.diff
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> This was originally the requirement to unblock a queue. However after first implemented it seemed better to modify purge, which purges all, to purge just the top message or the top n messages.
> I want to at a test so that this gets tested on make check. (Currently there is not a check for the purge at all).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.