[GitHub] [spark] cloud-fan commented on a change in pull request #35609: [SPARK-38286][SQL] Union's maxRows and maxRowsPerPartition may overflow

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #35609:
URL: https://github.com/apache/spark/pull/35609#discussion_r812966259



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
##########
@@ -277,11 +277,18 @@ case class Union(
   assert(!allowMissingCol || byName, "`allowMissingCol` can be true only if `byName` is true.")
 
   override def maxRows: Option[Long] = {
-    if (children.exists(_.maxRows.isEmpty)) {

Review comment:
       do you know which Spark version we start to have `Union.maxRows`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org