You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by "himanshukandwal (via GitHub)" <gi...@apache.org> on 2023/12/19 20:53:27 UTC

[PR] Helix -- Improves CI/CD Performance [test-src only] [helix]

himanshukandwal opened a new pull request, #2716:
URL: https://github.com/apache/helix/pull/2716

   ### Issues
   
   - [x] My PR addresses the following Helix issues and references them in the PR description:
   In this PR, we are addressing the overall helix CI/CD performance.
   
   ### Description
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   Changes to Boost performance include:
   * Removal of `System.out.println` statements. Moving important ones to `LOG.info`
   * Using a standardized Helix ZK Client (TestHelper#createZkClient) with shorter timeouts (ConnectInitTimeout, OperationRetryTimeout, SessionTimeout)
   * Removed un-necessary Thread.sleep (especially  after syncStop and syncStart statements).
   * Avoided adding all the BuiltInStateModelDefinitions unnecessarily. Added on-demand bases, depending on the resource type.
   
   Improved Runtime: 1h 30m
   Previous Runtime: 2h 10m 
   
   https://github.com/himanshukandwal/helix/actions/runs/7264671258
   
   
   ### Tests
   
   - [x] The following tests are written for this issue:
   N/A
   
   - The following is the result of the "mvn test" command on the appropriate module:
   
   https://github.com/himanshukandwal/helix/actions/runs/7264671258
   
   ### Changes that Break Backward Compatibility (Optional)
   
   - My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
   
   (Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
   
   ### Documentation (Optional)
   
   - In case of new functionality, my PR adds documentation in the following wiki page:
   
   (Link the GitHub wiki you added)
   
   ### Commits
   
   - My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Code Quality
   
   - My diff has been formatted using helix-style.xml 
   (helix-style-intellij.xml if IntelliJ IDE is used)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org


Re: [PR] Helix -- Improves CI/CD Performance [test-src only] [helix]

Posted by "himanshukandwal (via GitHub)" <gi...@apache.org>.
himanshukandwal closed pull request #2716: Helix --  Improves CI/CD Performance [test-src only]
URL: https://github.com/apache/helix/pull/2716


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org


Re: [PR] Helix -- Improves CI/CD Performance [test-src only] [helix]

Posted by "xyuanlu (via GitHub)" <gi...@apache.org>.
xyuanlu commented on PR #2716:
URL: https://github.com/apache/helix/pull/2716#issuecomment-1865379789

   Quick question. I dont think we have info or lower level log in CI test result script. Will changing from print to log reduce debuggability? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org