[GitHub] [couchdb] rnewson opened a new pull request #2137: Send a 500, not a 400, for unknown search errors

[GitBox <gi...@apache.org>]

rnewson opened a new pull request #2137: Send a 500, not a 400, for unknown search errors
URL: https://github.com/apache/couchdb/pull/2137
 
 
   ## Overview
   
   We should only send a 400 Bad Request if there is genuinely something
   wrong with the request, otherwise we mislead users and sysadmins.
   
   ## Testing recommendations
   
   Induce a search failure that is unrelated to the request itself, confirm you get a 500 status code.
   
   This does change existing behaviour, but in a good way. Only genuinely bad requests will get a 400 code.
   
   ## Related Issues or Pull Requests
   
   N/A
   
   ## Checklist
   
   - [x] Code is written and works correctly
   - [ ] Changes are covered by tests
   - [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
   - [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
   
   (no existing test to update. No new config params. The `_find` endpoint already documented to throw a 500).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services