You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/01/08 17:47:38 UTC

[GitHub] yuxihu commented on a change in pull request #13795: add extra header file to include

yuxihu commented on a change in pull request #13795: add extra header file to include
URL: https://github.com/apache/incubator-mxnet/pull/13795#discussion_r246090709
 
 

 ##########
 File path: plugin/opencv/cv_api.cc
 ##########
 @@ -26,9 +26,9 @@
 #include <dmlc/base.h>
 #include <mxnet/base.h>
 #include <mxnet/ndarray.h>
+#include <mxnet/c_api_common.h>
 
 Review comment:
   QQ: do we have guideline regarding the order of putting include files? Shall we follow alphabetic order of the filename? If so, please move this include to the right place here and all other places in this PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services