You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by lu...@apache.org on 2009/08/28 02:39:17 UTC

svn commit: r808693 - in /myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/view/facelets/tag/jsf: ComponentSupport.java ComponentTagHandlerDelegate.java ValidateHandler.java

Author: lu4242
Date: Fri Aug 28 00:39:17 2009
New Revision: 808693

URL: http://svn.apache.org/viewvc?rev=808693&view=rev
Log:
MYFACES-2310 Implement Composite Component feature (remove/add todos or comments)

Modified:
    myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/view/facelets/tag/jsf/ComponentSupport.java
    myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/view/facelets/tag/jsf/ComponentTagHandlerDelegate.java
    myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/view/facelets/tag/jsf/ValidateHandler.java

Modified: myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/view/facelets/tag/jsf/ComponentSupport.java
URL: http://svn.apache.org/viewvc/myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/view/facelets/tag/jsf/ComponentSupport.java?rev=808693&r1=808692&r2=808693&view=diff
==============================================================================
--- myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/view/facelets/tag/jsf/ComponentSupport.java (original)
+++ myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/view/facelets/tag/jsf/ComponentSupport.java Fri Aug 28 00:39:17 2009
@@ -221,6 +221,25 @@
 
         return facesContext.getViewRoot();
     }
+   
+    /*
+    public static UniqueIdVendor getClosestUniqueIdVendor(UIComponent parent)
+    {
+        UIComponent c = parent;
+        do
+        {
+            if (c instanceof UniqueIdVendor)
+            {
+                return (UniqueIdVendor) c;
+            }
+            else
+            {
+                c = c.getParent();
+            }
+        } while (c != null);
+
+        return null;
+    }*/
 
     /**
      * Marks all direct children and Facets with an attribute for deletion.
@@ -307,10 +326,12 @@
      * Determine if the passed component is not null and if it's new to the tree. This operation can be used for
      * determining if attributes should be wired to the component.
      * 
+     * @deprecated use ComponentHandler.isNew
      * @param component
      *            the component you wish to modify
      * @return true if it's new
      */
+    @Deprecated
     public static boolean isNew(UIComponent component)
     {
         return component != null && component.getParent() == null;

Modified: myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/view/facelets/tag/jsf/ComponentTagHandlerDelegate.java
URL: http://svn.apache.org/viewvc/myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/view/facelets/tag/jsf/ComponentTagHandlerDelegate.java?rev=808693&r1=808692&r2=808693&view=diff
==============================================================================
--- myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/view/facelets/tag/jsf/ComponentTagHandlerDelegate.java (original)
+++ myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/view/facelets/tag/jsf/ComponentTagHandlerDelegate.java Fri Aug 28 00:39:17 2009
@@ -136,9 +136,6 @@
                 log.fine(_delegate.getTag() + " Component[" + id + "] Created: " + c.getClass().getName());
             }
             
-            // TODO: What should we have to do for composite components?
-            // It depends on how composite:attribute works and which MetaRuleset
-            // is applied.
             _delegate.setAttributes(ctx, c);
 
             // mark it owned by a facelet instance

Modified: myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/view/facelets/tag/jsf/ValidateHandler.java
URL: http://svn.apache.org/viewvc/myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/view/facelets/tag/jsf/ValidateHandler.java?rev=808693&r1=808692&r2=808693&view=diff
==============================================================================
--- myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/view/facelets/tag/jsf/ValidateHandler.java (original)
+++ myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/view/facelets/tag/jsf/ValidateHandler.java Fri Aug 28 00:39:17 2009
@@ -72,7 +72,6 @@
     }
 
     /**
-     * TODO
      * 
      * @see javax.faces.view.facelets.FaceletHandler#apply(javax.faces.view.facelets.FaceletContext, javax.faces.component.UIComponent)
      */