[GitHub] [airflow] ashb commented on a change in pull request #6855: [AIRFLOW-6307] Improve support for a special characters in DAG's name in stats view

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #6855: [AIRFLOW-6307] Improve support for a special characters in DAG's name in stats view
URL: https://github.com/apache/airflow/pull/6855#discussion_r360354337
 
 

 ##########
 File path: airflow/www/views.py
 ##########
 @@ -307,7 +307,7 @@ def dag_stats(self, session=None):
 
         # Filter by get parameters
         selected_dag_ids = {
-            unquote(dag_id) for dag_id in request.args.get('dag_ids', '').split(',') if dag_id
+            unquote(dag_id) for dag_id in request.args.getlist('dag_ids[]') if dag_id
 
 Review comment:
   ```suggestion
               unquote(dag_id) for dag_id in request.args.getlist('dag_ids') if dag_id
   ```
   
   There's no requirement on `[]` got `getlist`, and both of those characters get url-escaped which just makes the URL a bit ugly is all (and longer) :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services