[GitHub] [pulsar] poorbarcode commented on pull request #15474: [fix][broker] Fix cannot cleanup expired ledger by trim ledgers

[GitBox <gi...@apache.org>]

poorbarcode commented on PR #15474:
URL: https://github.com/apache/pulsar/pull/15474#issuecomment-1120102937

   Good catch.  This patch solved the problem to some extent,  I think the solution is that the newly created persistent subscription 'cursor position' is always greater than 'message-TTL' and the 'message-TTL' policy is enabled.
   
   I have two questions:
   
   - 1
   
   > And then if we have a flink task consumer the topic( use reader to consumer and mark position by another durable cursor), the client will always reset the durable cursor to the position.
   
   why not use nodurable Reader ?
   
   - 2
   
   ```java
   ledgerClosed(lh);
   createLedgerAfterClosed();
   ```
   This should ensure that a new-leadger is always created when the old-leadger is closed. If this is necessary, a comment should be added to remind others later, better have a unit test to ensure that.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org