You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Rogier Dikkes <r....@gmail.com> on 2017/11/16 10:01:50 UTC
Review Request 63871: Improve Vagrant setup with vagrant-hostmanager
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63871/
-----------------------------------------------------------
Review request for Aurora.
Repository: aurora
Description
-------
Improve Vagrant setup with vagrant-hostmanager
Diffs
-----
Vagrantfile 2c4d23aa1b063d11cbf2d9d24e1b4e7a39437513
docs/getting-started/vagrant.md ca4b704ca5a50b245d62e73321336c79705a3f6e
Diff: https://reviews.apache.org/r/63871/diff/1/
Testing
-------
Thanks,
Rogier Dikkes
Re: Review Request 63871: Improve Vagrant setup with
vagrant-hostmanager
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63871/#review191167
-----------------------------------------------------------
Ship it!
Master (46b1112) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Nov. 16, 2017, 10:05 a.m., Rogier Dikkes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63871/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2017, 10:05 a.m.)
>
>
> Review request for Aurora, Joshua Cohen and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Improve Vagrant setup with vagrant-hostmanager
>
> Currently the vagrant devcluster is setup with aurora.local in the /etc/hosts file of the guest virtual machine, however the /etc/hosts file on the host machine where Vagrant is running on does not get changed. Result is that clients outside of the Vagrant environment have issues connecting to the devcluster, also the url within the devcluster environment do not work when you use it from your browser. An example of this is the url of the aurora framework in the Mesos master page.
>
> Found vagrant-hostmanager which is easy to implement, it generates the /etc/hosts and removes entries upon destroying the Vagrant setup. It also has the ability to add entries within the Vagrant environment, for now i left that out of the scope of this issue.
>
>
> Diffs
> -----
>
> Vagrantfile 2c4d23aa1b063d11cbf2d9d24e1b4e7a39437513
> docs/getting-started/vagrant.md ca4b704ca5a50b245d62e73321336c79705a3f6e
>
>
> Diff: https://reviews.apache.org/r/63871/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rogier Dikkes
>
>
Re: Review Request 63871: Improve Vagrant setup with
vagrant-hostmanager
Posted by Rogier Dikkes <r....@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63871/
-----------------------------------------------------------
(Updated Nov. 16, 2017, 10:05 a.m.)
Review request for Aurora.
Changes
-------
Added description with more information what this is about
Repository: aurora
Description (updated)
-------
Improve Vagrant setup with vagrant-hostmanager
Currently the vagrant devcluster is setup with aurora.local in the /etc/hosts file of the guest virtual machine, however the /etc/hosts file on the host machine where Vagrant is running on does not get changed. Result is that clients outside of the Vagrant environment have issues connecting to the devcluster, also the url within the devcluster environment do not work when you use it from your browser. An example of this is the url of the aurora framework in the Mesos master page.
Found vagrant-hostmanager which is easy to implement, it generates the /etc/hosts and removes entries upon destroying the Vagrant setup. It also has the ability to add entries within the Vagrant environment, for now i left that out of the scope of this issue.
Diffs
-----
Vagrantfile 2c4d23aa1b063d11cbf2d9d24e1b4e7a39437513
docs/getting-started/vagrant.md ca4b704ca5a50b245d62e73321336c79705a3f6e
Diff: https://reviews.apache.org/r/63871/diff/1/
Testing
-------
Thanks,
Rogier Dikkes