[GitHub] [geode] jdeppe-pivotal opened pull request #3395: GEODE-6589: Parameterize gradle project group for use in GradleBuildWithGeodeCoreAcceptanceTest

["jdeppe-pivotal (GitHub)" <gi...@apache.org>]

Authored-by: Jens Deppe <jd...@pivotal.io>

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/3395 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dickcav commented on pull request #3395: GEODE-6589: Parameterize gradle project group for use in GradleBuildWithGeodeCoreAcceptanceTest

["dickcav (GitHub)" <gi...@apache.org>]

Please add a comment as to why this is a different version and to leave it this version when gradle is rev'd. 

[ Full content available at: https://github.com/apache/geode/pull/3395 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] PurelyApplied commented on pull request #3395: GEODE-6589: Parameterize gradle project group for use in GradleBuildWithGeodeCoreAcceptanceTest

["PurelyApplied (GitHub)" <gi...@apache.org>]

What was the reason for the roll-back?

[ Full content available at: https://github.com/apache/geode/pull/3395 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] PurelyApplied commented on pull request #3395: GEODE-6589: Parameterize gradle project group for use in GradleBuildWithGeodeCoreAcceptanceTest

["PurelyApplied (GitHub)" <gi...@apache.org>]

See top-level comment, but this should probably read
```
 build.withArguments("-Pversion=" + geodeVersion,
        "-Pgroup=" + projectGroup,
        "-PgeodeHome=" + geodeHome.toString());
```

[ Full content available at: https://github.com/apache/geode/pull/3395 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jdeppe-pivotal commented on issue #3395: GEODE-6589: Parameterize gradle project group for use in GradleBuildWithGeodeCoreAcceptanceTest

["jdeppe-pivotal (GitHub)" <gi...@apache.org>]

Test failures are unrelated to this change

[ Full content available at: https://github.com/apache/geode/pull/3395 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jdeppe-pivotal commented on pull request #3395: GEODE-6589: Parameterize gradle project group for use in GradleBuildWithGeodeCoreAcceptanceTest

["jdeppe-pivotal (GitHub)" <gi...@apache.org>]

I've added a comment here. Somewhat unrelated but in other situations this test fails because of gradle file locking issues.

[ Full content available at: https://github.com/apache/geode/pull/3395 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jdeppe-pivotal commented on pull request #3395: GEODE-6589: Parameterize gradle project group for use in GradleBuildWithGeodeCoreAcceptanceTest

["jdeppe-pivotal (GitHub)" <gi...@apache.org>]

Done


[ Full content available at: https://github.com/apache/geode/pull/3395 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jdeppe-pivotal closed pull request #3395: GEODE-6589: Parameterize gradle project group for use in GradleBuildWithGeodeCoreAcceptanceTest

["jdeppe-pivotal (GitHub)" <gi...@apache.org>]

[ pull request closed by jdeppe-pivotal ]

[ Full content available at: https://github.com/apache/geode/pull/3395 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] PurelyApplied commented on pull request #3395: GEODE-6589: Parameterize gradle project group for use in GradleBuildWithGeodeCoreAcceptanceTest

["PurelyApplied (GitHub)" <gi...@apache.org>]

See top-level comment, but this should probably read
`compile("${project.group}:geode-core:${project.version}")`

[ Full content available at: https://github.com/apache/geode/pull/3395 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org