[GitHub] [incubator-dolphinscheduler] CalvinKirs commented on a change in pull request #4013: [Improvement-4012][common/remote] Json util code integration,remove the remote module json util

[GitBox <gi...@apache.org>]

CalvinKirs commented on a change in pull request #4013:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4013#discussion_r517324068



##########
File path: dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java
##########
@@ -253,6 +268,24 @@ public static String toJsonString(Object object) {
         }
     }
 
+    /**
+     * serialize to json byte
+     *
+     * @param obj object
+     * @param <T> object type
+     * @return byte array
+     */
+    public static <T> byte[] toJsonByteArray(T obj)  {
+        String json = "";

Review comment:
       Here should be a null operation on obj.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org