[jira] [Resolved] (MSHARED-514) if filter file does not exist it should optionally ignore it, not just throw an exception

["Elliotte Rusty Harold (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/MSHARED-514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Elliotte Rusty Harold resolved MSHARED-514.
-------------------------------------------
    Resolution: Fixed

Since there's no activity here and this issue is scheduled for autoclosure anyway, I'm going to make an opinionated call that we shouldn't fix this. The current behavior is reasonable, and we have too many options to document and support already.

> if filter file does not exist it should optionally ignore it, not just throw an exception
> -----------------------------------------------------------------------------------------
>
>                 Key: MSHARED-514
>                 URL: https://issues.apache.org/jira/browse/MSHARED-514
>             Project: Maven Shared Components
>          Issue Type: Improvement
>          Components: maven-filtering
>    Affects Versions: maven-filtering-3.1.0
>            Reporter: richard stevenson
>            Assignee: Olivier Lamy
>            Priority: Minor
>         Attachments: maven-filter.patch
>
>
> If you have a list of filter files
> <filters>
>   <filter>a.properties</filter>
>   <filter>b.properties</filter>
>   <filter>${prop.name}.properties</filter>
> </filters>
> It would be nice to tell the resources plugin to optioanlly ignore a file if it does not exist. Currently get the following stack trace:
> org.apache.maven.lifecycle.LifecycleExecutionException: Error loading property f
> ile 'D:\projects\.../src/main/filters/a.filter.properties'
>         at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(Defa
> ultLifecycleExecutor.java:719)
>         at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLi
> fecycle(DefaultLifecycleExecutor.java:556)
>         at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(Defau
> ltLifecycleExecutor.java:535)
>         at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHan
> dleFailures(DefaultLifecycleExecutor.java:387)
>         at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegmen
> ts(DefaultLifecycleExecutor.java:348)
>         at org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLi
> fecycleExecutor.java:180)
>         at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:328)
>         at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:138)
>         at org.apache.maven.cli.MavenCli.main(MavenCli.java:362)
>         at org.apache.maven.cli.compat.CompatibleMain.main(CompatibleMain.java:6
> 0)
>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>         at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.
> java:39)
>         at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAcces
> sorImpl.java:25)
>         at java.lang.reflect.Method.invoke(Method.java:597)
>         at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
>         at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
>         at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
>         at org.codehaus.classworlds.Launcher.main(Launcher.java:375)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Error loading propert
> y file 'D:\projects\.../src/main/filters/a.filter.properties'
>         at org.apache.maven.plugin.resources.ResourcesMojo.execute(ResourcesMojo
> .java:269)
>         at org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPlugi
> nManager.java:490)
>         at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(Defa
> ultLifecycleExecutor.java:694)
>         ... 17 more
> Caused by: org.apache.maven.shared.filtering.MavenFilteringException: Error load
> ing property file 'D:\projects\.../src/main/filters/a.properties'
>         at org.apache.maven.shared.filtering.DefaultMavenFileFilter.loadProperti
> es(DefaultMavenFileFilter.java:274)
>         at org.apache.maven.shared.filtering.DefaultMavenFileFilter.getDefaultFi
> lterWrappers(DefaultMavenFileFilter.java:199)
>         at org.apache.maven.shared.filtering.DefaultMavenResourcesFiltering.filt
> erResources(DefaultMavenResourcesFiltering.java:162)
>         at org.apache.maven.plugin.resources.ResourcesMojo.execute(ResourcesMojo
> .java:265)
>         ... 19 more
> Caused by: java.io.FileNotFoundException: D:\projects\.../src/main/filters/a.fil
> ter.properties
>         at org.apache.maven.shared.filtering.PropertyUtils.loadPropertyFile(Prop
> ertyUtils.java:65)
>         at org.apache.maven.shared.filtering.DefaultMavenFileFilter.loadProperti
> es(DefaultMavenFileFilter.java:269)
>         ... 22 more



--
This message was sent by Atlassian Jira
(v8.3.4#803005)