You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by GitBox <gi...@apache.org> on 2022/08/12 18:49:51 UTC
[GitHub] [phoenix-omid] apurtell opened a new pull request, #111: OMID-226 Migrate from mockito-all to mockito-core and clean up test dependencies
apurtell opened a new pull request, #111:
URL: https://github.com/apache/phoenix-omid/pull/111
At some point OMID will upgrade to latest Hadoop 2.10 and HBase 2.4 releases and will then experience IncompatibleClassChangeErrors in unit tests due to a conflict between mockito-all used here and mockito-core used by Hadoop, HBase, and Phoenix. Prepare for this by migrating from mockito-all to mockito-core now.
Update matchers in some unit tests for minor differences in mocking and matching behavior after the migration.
Clean up test dependency declarations in POMs while at it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-omid] stoty commented on pull request #111: OMID-226 Migrate from mockito-all to mockito-core and clean up test dependencies
Posted by GitBox <gi...@apache.org>.
stoty commented on PR #111:
URL: https://github.com/apache/phoenix-omid/pull/111#issuecomment-1237752282
@apurtell Can you merge this when you're back ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-omid] stoty commented on a diff in pull request #111: OMID-226 Migrate from mockito-all to mockito-core and clean up test dependencies
Posted by GitBox <gi...@apache.org>.
stoty commented on code in PR #111:
URL: https://github.com/apache/phoenix-omid/pull/111#discussion_r945433122
##########
pom.xml:
##########
@@ -168,7 +168,7 @@
<protobuf.plugin.version>0.6.1</protobuf.plugin.version>
<os.plugin.version>1.6.2</os.plugin.version>
<junit.version>4.13.1</junit.version>
- <mockito.version>1.10.19</mockito.version>
+ <mockito-core.version>2.28.2</mockito-core.version>
Review Comment:
nit:
AFAIK the mockito libraries have a single common version, we could keep using mockito.version as the property name, even if we only pull mockito-core.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-omid] apurtell commented on pull request #111: OMID-226 Migrate from mockito-all to mockito-core and clean up test dependencies
Posted by GitBox <gi...@apache.org>.
apurtell commented on PR #111:
URL: https://github.com/apache/phoenix-omid/pull/111#issuecomment-1213418408
All unit tests passed for me locally before I pushed this up.
Phoenix itself is using mockito-core 1.x and should align with HBase, which is using 2.28.2 on branch-2.4 and branch-2.5, but this is out of scope of this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org