You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "raiden00pl (via GitHub)" <gi...@apache.org> on 2024/10/15 13:15:19 UTC
[PR] libs/libxx: uClibc depends on CONFIG_ALLOW_GPL_COMPONENTS=y [nuttx]
raiden00pl opened a new pull request, #14328:
URL: https://github.com/apache/nuttx/pull/14328
## Summary
libs/libxx: uClibc depends on CONFIG_ALLOW_GPL_COMPONENTS=y
uClibc is LGPL so it should depends on CONFIG_ALLOW_GPL_COMPONENTS=y
https://www.uclibc.org/FAQ.html#licensing
## Impact
LGPL code must be protected by CONFIG_ALLOW_GPL_COMPONENTS option.
## Testing
none
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] libs/libxx: uClibc depends on CONFIG_ALLOW_GPL_COMPONENTS=y [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #14328:
URL: https://github.com/apache/nuttx/pull/14328#issuecomment-2416794895
> @jerpelea there are 3 types of GPL configs in NuttX now:
>
> 1. socketCAN related apps - but these components are dual licence (GPL-2.0-only OR BSD-3-Clause) and I don't understand why they depend on GPL at all. We can use BSD-3 for them and then we don't have dependency on GPL
>
> 2. uClibc which is LGPL and there's no doubt about it. We can remove these configurations, then we lose coverage in CI, or warn the user in some other visible way (maybe big warning during compilation?)
>
>
> And another thing is `drivers/video/ov2640.c` file, which I have no idea how to hadle.
1. Agreed, should be moved to BSD COMPONENT
2. An alternative is using a bit flag, everything some GPL/LGPL code is compiled/linked it is enabled and a message could be printed just before the NSH start. A warning during the compilation could be easy missed
3. I think ov2640 is not GPL code at all, as I remember @patacongo just looked the initialization table that was from some GPL driver, but AFAIK Omnivision supply it as sample code as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] libs/libxx: uClibc depends on CONFIG_ALLOW_GPL_COMPONENTS=y [nuttx]
Posted by "raiden00pl (via GitHub)" <gi...@apache.org>.
raiden00pl commented on PR #14328:
URL: https://github.com/apache/nuttx/pull/14328#issuecomment-2414271376
ALLOW_GPL_COMPONENTS is for both: GPL and LGPL:
```
config ALLOW_GPL_COMPONENTS
bool "Use components that have GPL/LGPL licenses"
default n
```
from ASF perspective both are in the same category: https://www.apache.org/legal/resolved.html#category-x
We don't use uClibc as linked library but compile its code directly and there are some controversy about object-oriented programming and LGPL-licensed code (which was solved in LGPL v3, but this code is LGPL v2.1), so I don't know if LGPL has any meaning here at all.
I think it's safer to keep copyleft licenses as one option, but maybe someone who knows something more about licenses has a different opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] libs/libxx: uClibc depends on CONFIG_ALLOW_GPL_COMPONENTS=y [nuttx]
Posted by "raiden00pl (via GitHub)" <gi...@apache.org>.
raiden00pl commented on PR #14328:
URL: https://github.com/apache/nuttx/pull/14328#issuecomment-2419003723
> An alternative is using a bit flag, everything some GPL/LGPL code is compiled/linked it is enabled and a message could be printed just before the NSH start. A warning during the compilation could be easy missed
The problem with this approach is that nuttx-apps and NSH is optional, not all users use them. Information like this should be displayed to every user, so it should be on the kernel side
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] libs/libxx: uClibc depends on CONFIG_ALLOW_GPL_COMPONENTS=y [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #14328:
URL: https://github.com/apache/nuttx/pull/14328
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] libs/libxx: uClibc depends on CONFIG_ALLOW_GPL_COMPONENTS=y [nuttx]
Posted by "jerpelea (via GitHub)" <gi...@apache.org>.
jerpelea commented on PR #14328:
URL: https://github.com/apache/nuttx/pull/14328#issuecomment-2416346341
@raiden00pl
I think that the GPL components should not be placed in NuttX git, they should be moved to the apps git
GPL components should never be enabled by default because there is a high risk that they are overlooked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] libs/libxx: uClibc depends on CONFIG_ALLOW_GPL_COMPONENTS=y [nuttx]
Posted by "raiden00pl (via GitHub)" <gi...@apache.org>.
raiden00pl commented on PR #14328:
URL: https://github.com/apache/nuttx/pull/14328#issuecomment-2416323419
@acassis keeping it as a GPL dependency is a defensive move to protect the user. If the code is LGPL then we leave it up to the user to determine what the resulting license for their project will be. In the case of copyleft licenses, it's better to assume the worst case scenario.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] libs/libxx: uClibc depends on CONFIG_ALLOW_GPL_COMPONENTS=y [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #14328:
URL: https://github.com/apache/nuttx/pull/14328#issuecomment-2417005194
CONFIG_xxx can be got from:
1. elf debug info or
2. https://github.com/apache/nuttx-apps/tree/master/system/nxdiag
so, don't need invent another method to get the same information again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] libs/libxx: uClibc depends on CONFIG_ALLOW_GPL_COMPONENTS=y [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #14328:
URL: https://github.com/apache/nuttx/pull/14328#issuecomment-2414113424
@raiden00pl GPL and LGPL are different licenses, should we create a CONFIG_ALLOW_LGPL_COMPONENTS for this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] libs/libxx: uClibc depends on CONFIG_ALLOW_GPL_COMPONENTS=y [nuttx]
Posted by "raiden00pl (via GitHub)" <gi...@apache.org>.
raiden00pl commented on PR #14328:
URL: https://github.com/apache/nuttx/pull/14328#issuecomment-2416400717
there are 3 types of GPL configs in NuttX now:
1. socketCAN related apps - but these components are dual licence (GPL-2.0-only OR BSD-3-Clause) and I don't understand why they depend on GPL at all. We can use BSD-3 for them and then we don't have dependency on GPL
2. uClibc which is LGPL and there's no doubt about it. We can remove these configurations, then we lose coverage in CI, or warn the user in some other visible way (maybe big warning during compilation?)
And another thing is `drivers/video/ov2640.c` file, which I have no idea how to hadle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] libs/libxx: uClibc depends on CONFIG_ALLOW_GPL_COMPONENTS=y [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #14328:
URL: https://github.com/apache/nuttx/pull/14328#discussion_r1801323266
##########
libs/libxx/Kconfig:
##########
@@ -53,6 +53,7 @@ config LIBCXX
config UCLIBCXX
bool "uClibc++ Standard C++ Library"
select HAVE_CXXINITIALIZE
+ depends on ALLOW_GPL_COMPONENTS
Review Comment:
should be change to LGPL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] libs/libxx: uClibc depends on CONFIG_ALLOW_GPL_COMPONENTS=y [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #14328:
URL: https://github.com/apache/nuttx/pull/14328#issuecomment-2415186572
> ALLOW_GPL_COMPONENTS is for both: GPL and LGPL:
>
> ```
> config ALLOW_GPL_COMPONENTS
> bool "Use components that have GPL/LGPL licenses"
> default n
> ```
>
> from ASF perspective both are in the same category: https://www.apache.org/legal/resolved.html#category-x We don't use uClibc as linked library but compile its code directly and there are some controversy about object-oriented programming and LGPL-licensed code (which was solved in LGPL v3, but this code is LGPL v2.1), so I don't know if LGPL has any meaning here at all.
>
> I think it's safer to keep copyleft licenses as one option, but maybe someone who knows something more about licenses has a different opinion.
I'm not license expert either, but...
In theory LGPL you don't need to release the source code, even with statically linked (but you need to release the file objects to be linked with new library version). But again this is a grey area, so maybe it is better keep GPL/LGPL as a GPL, this way the users will be aware of the issue.
Maybe we should consider printing a message before the nsh> show up to let users know that the code is linked against LGPL and the source code need to be released case the product is used for commercial application
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org