You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by Giacomo Pati <Gi...@pwr.ch> on 2000/09/29 20:28:03 UTC
Re: cvs commit: xml-cocoon/webapp sitemap.xmap
stefano@locus.apache.org wrote:
>
> stefano 00/09/28 18:06:54
>
> Modified: webapp Tag: xml-cocoon2 sitemap.xmap
> Log:
> updated the link serializer class
>
> Revision Changes Path
> No revision
>
>
> No revision
>
>
> 1.1.2.17 +2 -1 xml-cocoon/webapp/Attic/sitemap.xmap
>
> Index: sitemap.xmap
> ===================================================================
> RCS file: /home/cvs/xml-cocoon/webapp/Attic/sitemap.xmap,v
> retrieving revision 1.1.2.16
> retrieving revision 1.1.2.17
> diff -u -r1.1.2.16 -r1.1.2.17
> --- sitemap.xmap 2000/09/27 22:55:07 1.1.2.16
> +++ sitemap.xmap 2000/09/29 01:06:54 1.1.2.17
> @@ -21,6 +21,7 @@
> <map:transformer name="log" src="org.apache.cocoon.transformation.LogTransformer"/>
> <map:transformer name="sql" src="org.apache.cocoon.transformation.SQLTransformer"/>
> <map:transformer name="xinclude" src="org.apache.cocoon.transformation.XIncludeTransformer"/>
> + <map:transformer name="link" src="org.apache.cocoon.sitemap.LinkTranslator"/>
Do you think this component should be specified in the sitemap?
Personally I think it's a component similar to the ErrorNotifier and the
sitemap will know about it per default. What do you think?
> </map:transformers>
>
> <map:readers default="resource">
> @@ -28,7 +29,7 @@
> </map:readers>
>
> <map:serializers default="html">
> - <map:serializer name="links" src="org.apache.cocoon.serialization.XLinkSerializer"/>
> + <map:serializer name="links" src="org.apache.cocoon.serialization.LinkSerializer"/>
The same is true for this Serializer I think.
Giacomo
--
PWR GmbH, Organisation & Entwicklung Tel: +41 (0)1 856 2202
Giacomo Pati, CTO/CEO Fax: +41 (0)1 856 2201
Hintereichenstrasse 7 Mobil: +41 (0)78 759 7703
CH-8166 Niederweningen Mailto:Giacomo.Pati@pwr.ch
Web: http://www.pwr.ch
Re: cvs commit: xml-cocoon/webapp sitemap.xmap
Posted by Giacomo Pati <Gi...@pwr.ch>.
Stefano Mazzocchi wrote:
>
> Giacomo Pati wrote:
> >
> > stefano@locus.apache.org wrote:
> > >
> > > stefano 00/09/28 18:06:54
> > >
> > > Modified: webapp Tag: xml-cocoon2 sitemap.xmap
> > > Log:
> > > updated the link serializer class
> > >
> > > Revision Changes Path
> > > No revision
> > >
> > >
> > > No revision
> > >
> > >
> > > 1.1.2.17 +2 -1 xml-cocoon/webapp/Attic/sitemap.xmap
> > >
> > > Index: sitemap.xmap
> > > ===================================================================
> > > RCS file: /home/cvs/xml-cocoon/webapp/Attic/sitemap.xmap,v
> > > retrieving revision 1.1.2.16
> > > retrieving revision 1.1.2.17
> > > diff -u -r1.1.2.16 -r1.1.2.17
> > > --- sitemap.xmap 2000/09/27 22:55:07 1.1.2.16
> > > +++ sitemap.xmap 2000/09/29 01:06:54 1.1.2.17
> > > @@ -21,6 +21,7 @@
> > > <map:transformer name="log" src="org.apache.cocoon.transformation.LogTransformer"/>
> > > <map:transformer name="sql" src="org.apache.cocoon.transformation.SQLTransformer"/>
> > > <map:transformer name="xinclude" src="org.apache.cocoon.transformation.XIncludeTransformer"/>
> > > + <map:transformer name="link" src="org.apache.cocoon.sitemap.LinkTranslator"/>
> >
> > Do you think this component should be specified in the sitemap?
> > Personally I think it's a component similar to the ErrorNotifier and the
> > sitemap will know about it per default. What do you think?
>
> Agreed. Sorry, this went in by mistake since I was trying it out from
> the servlet interface to debug it (it still triggers some weird
> behavior)
>
> Consider it temporary.
Ok :)
> > > </map:transformers>
> > >
> > > <map:readers default="resource">
> > > @@ -28,7 +29,7 @@
> > > </map:readers>
> > >
> > > <map:serializers default="html">
> > > - <map:serializer name="links" src="org.apache.cocoon.serialization.XLinkSerializer"/>
> > > + <map:serializer name="links" src="org.apache.cocoon.serialization.LinkSerializer"/>
> >
> > The same is true for this Serializer I think.
>
> Here I disagree: the serializer is responsible to implement not only
> link serialization but also filtering based on rules. I would like this
> to be pluggable in an easy way so that people might add their own link
> filtering logic if they want.
>
> Besides, removing this would mean to create an implicit view and I'm
> against implicit things as much as possible since they are hard to
> visualize if they don't appear in the sitemap (recall that sitemap SVG
> posters will be generated out of the sitemap pages directly and implicit
> things might break the contracts).
>
> For link translation this is differen since it is not a view but a truly
> hidden behavior.
BTW: The picture you draw
g --> t --> t --+-> s
!
+ --> LT --> s
with the objectModel.get("links") != null.
Is the serializer on the LT path the LinkSerializer or the same
serializer as on the normal path?
Giacomo
--
PWR GmbH, Organisation & Entwicklung Tel: +41 (0)1 856 2202
Giacomo Pati, CTO/CEO Fax: +41 (0)1 856 2201
Hintereichenstrasse 7 Mobil: +41 (0)78 759 7703
CH-8166 Niederweningen Mailto:Giacomo.Pati@pwr.ch
Web: http://www.pwr.ch
Re: cvs commit: xml-cocoon/webapp sitemap.xmap
Posted by Stefano Mazzocchi <st...@apache.org>.
Giacomo Pati wrote:
>
> stefano@locus.apache.org wrote:
> >
> > stefano 00/09/28 18:06:54
> >
> > Modified: webapp Tag: xml-cocoon2 sitemap.xmap
> > Log:
> > updated the link serializer class
> >
> > Revision Changes Path
> > No revision
> >
> >
> > No revision
> >
> >
> > 1.1.2.17 +2 -1 xml-cocoon/webapp/Attic/sitemap.xmap
> >
> > Index: sitemap.xmap
> > ===================================================================
> > RCS file: /home/cvs/xml-cocoon/webapp/Attic/sitemap.xmap,v
> > retrieving revision 1.1.2.16
> > retrieving revision 1.1.2.17
> > diff -u -r1.1.2.16 -r1.1.2.17
> > --- sitemap.xmap 2000/09/27 22:55:07 1.1.2.16
> > +++ sitemap.xmap 2000/09/29 01:06:54 1.1.2.17
> > @@ -21,6 +21,7 @@
> > <map:transformer name="log" src="org.apache.cocoon.transformation.LogTransformer"/>
> > <map:transformer name="sql" src="org.apache.cocoon.transformation.SQLTransformer"/>
> > <map:transformer name="xinclude" src="org.apache.cocoon.transformation.XIncludeTransformer"/>
> > + <map:transformer name="link" src="org.apache.cocoon.sitemap.LinkTranslator"/>
>
> Do you think this component should be specified in the sitemap?
> Personally I think it's a component similar to the ErrorNotifier and the
> sitemap will know about it per default. What do you think?
Agreed. Sorry, this went in by mistake since I was trying it out from
the servlet interface to debug it (it still triggers some weird
behavior)
Consider it temporary.
> > </map:transformers>
> >
> > <map:readers default="resource">
> > @@ -28,7 +29,7 @@
> > </map:readers>
> >
> > <map:serializers default="html">
> > - <map:serializer name="links" src="org.apache.cocoon.serialization.XLinkSerializer"/>
> > + <map:serializer name="links" src="org.apache.cocoon.serialization.LinkSerializer"/>
>
> The same is true for this Serializer I think.
Here I disagree: the serializer is responsible to implement not only
link serialization but also filtering based on rules. I would like this
to be pluggable in an easy way so that people might add their own link
filtering logic if they want.
Besides, removing this would mean to create an implicit view and I'm
against implicit things as much as possible since they are hard to
visualize if they don't appear in the sitemap (recall that sitemap SVG
posters will be generated out of the sitemap pages directly and implicit
things might break the contracts).
For link translation this is differen since it is not a view but a truly
hidden behavior.
--
Stefano Mazzocchi One must still have chaos in oneself to be
able to give birth to a dancing star.
<st...@apache.org> Friedrich Nietzsche
--------------------------------------------------------------------
Missed us in Orlando? Make it up with ApacheCON Europe in London!
------------------------- http://ApacheCon.Com ---------------------