You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "xy2953396112 (via GitHub)" <gi...@apache.org> on 2026/02/03 06:34:46 UTC

[PR] [CELEBORN-2143] Create DiskFile sequentially based on createFileOrder [celeborn]

xy2953396112 opened a new pull request, #3594:
URL: https://github.com/apache/celeborn/pull/3594

   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     - Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
     - Be sure to keep the PR description updated to reflect all changes.
     - Please write your PR title to summarize what this PR proposes.
     - If possible, provide a concise example to reproduce the issue for a faster review.
   -->
   
   ### What changes were proposed in this pull request?
   
   Create DiskFile sequentially based on createFileOrder.
   
   ### Why are the changes needed?
   
   1. If the PartitionLocation specifies a StorageType (such as HDFS), DfsTierWriter should be created based on that StorageType.
   2. Optimize the storage strategy to create the logic for DiskFile.
   
   ### Does this PR resolve a correctness bug?
   
   NO
   
   ### Does this PR introduce _any_ user-facing change?
   
   NO
   
   ### How was this patch tested?
   
   CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-2143] Create DiskFile sequentially based on createFileOrder [celeborn]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3594:
URL: https://github.com/apache/celeborn/pull/3594#issuecomment-4168528471

   This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-2143] Create DiskFile sequentially based on createFileOrder [celeborn]

Posted by "eolivelli (via GitHub)" <gi...@apache.org>.
eolivelli commented on PR #3594:
URL: https://github.com/apache/celeborn/pull/3594#issuecomment-3888828506

   I am reviewing this patch.
   Can you please solve the conflicts ?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-2143] Create DiskFile sequentially based on createFileOrder [celeborn]

Posted by "eolivelli (via GitHub)" <gi...@apache.org>.
eolivelli commented on code in PR #3594:
URL: https://github.com/apache/celeborn/pull/3594#discussion_r2797894178


##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/StoragePolicy.scala:
##########
@@ -147,6 +146,25 @@ class StoragePolicy(conf: CelebornConf, storageManager: StorageManager, source:
                   partitionDataWriterContext,
                   storageManager)
               } else {
+                null

Review Comment:
   I suggest to add logDebug for these cases that return "null", sometimes I saw errors and I did not understand the reason



##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/StorageManager.scala:
##########
@@ -1213,9 +1170,80 @@ final private[worker] class StorageManager(conf: CelebornConf, workerSource: Abs
       }
       retryCount += 1
     }
+    if (dfsStorageAvailable) {
+      logWarning("Failed to create localFileWriter", exception)

Review Comment:
   please report shuffleId



##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/StoragePolicy.scala:
##########
@@ -158,10 +176,10 @@ class StoragePolicy(conf: CelebornConf, storageManager: StorageManager, source:
                   diskFileInfo.getStorageType,
                   partitionDataWriterContext,
                   storageManager)
+              } else {
+                null

Review Comment:
   also here and below



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-2143] Create DiskFile sequentially based on createFileOrder [celeborn]

Posted by "eolivelli (via GitHub)" <gi...@apache.org>.
eolivelli commented on PR #3594:
URL: https://github.com/apache/celeborn/pull/3594#issuecomment-3950564308

   @xy2953396112 in this PR I am adding a new suite of tests about TieredStorage
   https://github.com/apache/celeborn/pull/3608
   
   maybe you can build on top of that and add tests that cover your changes and demonstrate the problem you are solving ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-2143] Create DiskFile sequentially based on createFileOrder [celeborn]

Posted by "eolivelli (via GitHub)" <gi...@apache.org>.
eolivelli commented on code in PR #3594:
URL: https://github.com/apache/celeborn/pull/3594#discussion_r2811130226


##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/StorageManager.scala:
##########
@@ -1213,9 +1170,80 @@ final private[worker] class StorageManager(conf: CelebornConf, workerSource: Abs
       }
       retryCount += 1
     }
+    if (dfsStorageAvailable) {
+      logWarning("Failed to create localFileWriter", exception)
+      return (null, null, null)
+    }
     throw exception
   }
 
+  def createDfsDiskFile(
+      location: PartitionLocation,
+      appId: String,
+      shuffleId: Int,
+      fileName: String,
+      userIdentifier: UserIdentifier,
+      partitionType: PartitionType,
+      partitionSplitEnabled: Boolean): (Flusher, DiskFileInfo, File) = {
+    val shuffleKey = Utils.makeShuffleKey(appId, shuffleId)
+    if (location.getStorageInfo.HDFSAvailable()) {

Review Comment:
   I think that the better solution looks like this:
   https://github.com/Qbeast-io/celeborn/commit/460fc9b12ef1a523b565cd3df31254db1d7bf373#diff-332230b33db740720657fd9c90e4f4eb0bce18b43f4749fddfe37463cc11a9b1R1125-R1128
   
   we have to decouple the storage type to use from the "location"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-2143] Create DiskFile sequentially based on createFileOrder [celeborn]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3594:
URL: https://github.com/apache/celeborn/pull/3594#issuecomment-4231137279

   This issue was closed because it has been staled for 10 days with no activity.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-2143] Create DiskFile sequentially based on createFileOrder [celeborn]

Posted by "eolivelli (via GitHub)" <gi...@apache.org>.
eolivelli commented on PR #3594:
URL: https://github.com/apache/celeborn/pull/3594#issuecomment-3840036254

   hello @xy2953396112 
   in my PR https://github.com/apache/celeborn/pull/3592 I am adding some integration test to validate that S3 works
   
   maybe we could merge my patch and then rebase this patch ?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-2143] Create DiskFile sequentially based on createFileOrder [celeborn]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #3594: [CELEBORN-2143] Create DiskFile sequentially based on createFileOrder
URL: https://github.com/apache/celeborn/pull/3594


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org